Spell clean up #210
Merged
Spell clean up #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DSSpell related but DSS-Exec related
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 16, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
naszam
reviewed
Dec 17, 2021
iamchrissmith
force-pushed
the
spell-clean-up
branch
from
ff57951
to
2dd1aa9
Compare
iamchrissmith
force-pushed
the
spell-clean-up
branch
from
2dd1aa9
to
2f34a47
Compare
naszam
reviewed
Dec 17, 2021
naszam
previously approved these changes
Dec 17, 2021
Makefile
Outdated
| clean :; dapp clean | ||
| # Usage example: make test match=SpellIsCast | ||
| test :; ./test-dssspell.sh $(match) | ||
| test-dev :; ./test-dev-dssspell.sh $(match) |
There was a problem hiding this comment.
Rather than having two separate scripts here, what about one script that accepts an argument to enable dev mode?
That way when we make other changes as a result of tooling updates or whatever we don't need to reflect them in two separate files. In this case, the only real difference will be whether the optimizer is off or on.
There was a problem hiding this comment.
updated: fdc1a0b
I left the test-dev command in there for shorthand, let me know if that bothers you
naszam
reviewed
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up tasks for the DSS Spell.
It will likely be easier to review in parts. I've mostly batched changes into specific commits except collateral onboarding which is covered in the last few commits (21eb5a9 - f57951e)
List of tasks: https://github.com/makerdao/smart-contracts-team-pm/issues/747