PE-814: 2022-01-21 Executive

[godsflaw]

Description

PE-814: 2022-01-21 Executive

Contribution Checklist

• PR title starts with (PE-<TICKET_NUMBER>)
• Code approved
• Tests approved
• CI Tests pass

Checklist

• Every contract variable/method declared as public/external private/internal
• Consider if this PR needs the officeHours modifier
• Verify expiration (4 days monthly and 30 days for the rest)
• Verify hash in the description matches here
• Validate all addresses used are in changelog or known
• Notify any external teams affected by the spell so they have the opportunity to review
• Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• Verify mainnet contract on etherscan
• Change test to use mainnet spell address and deploy timestamp
• Run make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, and DssSpell.t.base.sol
• squash and merge this PR

[talbaneth]

Need to change the copyright to 2022 here as well :)

[talbaneth]

Made a small comment about the location of testAAVEDirectBarChange.
Apart from that this is good to deploy.

Verified:
-diffed the spell with goerli
-diffed config.sol with goerli
-diffed all files vs previous spell
-AAVE D3M updates - checked values vs sheet and poll
-reviewed tests
-tests pass

[iamchrissmith]

we should update this to include 2022: https://github.com/makerdao/spells-mainnet/pull/215/files#diff-c9c3998420c475f01de841ca5283ea49ce6c99080a8c6a3fdae77b097bef6778L3

[brianmcmichael]

Copyright dates updated at e11b200

[iamchrissmith]

confirmed changes against goerli and Aave D3M against executive spreadsheet. I have a question about the verification code, but other than that looking good.

test are running (and have been for about an hour...)

[talbaneth]

Hash confirmed.
Tests passing:

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 7236)
[PASS] test_auth_in_sources() (gas: 281473904825281)
[PASS] test_use_eta() (gas: 326431)
[PASS] testOnTime() (gas: 670795)
[PASS] test_nextCastTime() (gas: 327273)
[PASS] testFailTooEarly() (gas: 3457)
[PASS] test_bytecode_matches() (gas: 1190042)
[PASS] testAAVEDirectBarChange() (gas: 674578)
[PASS] test_auth() (gas: 281473912910764)
[PASS] testSpellIsCast_GENERAL() (gas: 7784572)
[PASS] testFailWrongDay() (gas: 3699)
[PASS] testCastCost() (gas: 672681)
[PASS] testFailTooLate() (gas: 3853)

[talbaneth]

LGTM for deployment.

[talbaneth]

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904825312)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 680295)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 1199542)
[PASS] testAAVEDirectBarChange() (gas: 684078)
[PASS] test_auth() (gas: 281473912910796)
[PASS] testSpellIsCast_GENERAL() (gas: 8981391)
[PASS] testFailWrongDay() (gas: 8699)
[PASS] testCastCost() (gas: 682181)
[PASS] testFailTooLate() (gas: 8853)

[brianmcmichael]

With deployed address:

dapp-test: rpc block: latest
Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904825312)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 680055)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 1199542)
[PASS] testAAVEDirectBarChange() (gas: 683838)
[PASS] test_auth() (gas: 281473912910796)
[PASS] testSpellIsCast_GENERAL() (gas: 8981151)
[PASS] testFailWrongDay() (gas: 8699)
[PASS] testCastCost() (gas: 681941)
[PASS] testFailTooLate() (gas: 8853)

[iamchrissmith]

tests with address pass at block number 14050237

Running 13 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12236)
[PASS] test_auth_in_sources() (gas: 281473904825312)
[PASS] test_use_eta() (gas: 333431)
[PASS] testOnTime() (gas: 680515)
[PASS] test_nextCastTime() (gas: 334273)
[PASS] testFailTooEarly() (gas: 8457)
[PASS] test_bytecode_matches() (gas: 1199542)
[PASS] testAAVEDirectBarChange() (gas: 684298)
[PASS] test_auth() (gas: 281473912910796)
[PASS] testSpellIsCast_GENERAL() (gas: 8981611)
[PASS] testFailWrongDay() (gas: 8699)
[PASS] testCastCost() (gas: 682401)
[PASS] testFailTooLate() (gas: 8853)

[talbaneth]

LGTM to merge.