Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161 Upgrade versions #178

Merged
merged 4 commits into from
Jan 31, 2020
Merged

#161 Upgrade versions #178

merged 4 commits into from
Jan 31, 2020

Conversation

makimenko
Copy link
Owner

  • upgraded to three 0.133.2
  • Switched to Angular CLI 9.0.0-rc.12 (to be verified)
  • Removed workaround: angularCompilerOptions.disableTypeScriptVersionCheck=true

The rest workarounds left:

  • added polyfills.ts: __importDefault
  • added __importDefault to test.ts

- upgraded to three 0.133.2
- Switched to Angular CLI 9.0.0-rc.12 (to be verified)
- Removed workaround: `angularCompilerOptions.disableTypeScriptVersionCheck=true`

The rest workarounds left:
- added polyfills.ts: __importDefault
- added __importDefault to test.ts
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #178 into master will decrease coverage by 2.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #178      +/-   ##
=========================================
- Coverage   77.91%   75.6%   -2.32%     
=========================================
  Files          78      78              
  Lines         951     951              
  Branches       94      94              
=========================================
- Hits          741     719      -22     
- Misses        166     188      +22     
  Partials       44      44
Impacted Files Coverage Δ
.../data-center/server/server-icon-actor.component.ts 50% <0%> (-50%) ⬇️
...ata-center/server/server-barrel-actor.component.ts 50% <0%> (-50%) ⬇️
...ta-center/server/server-compact-actor.component.ts 50% <0%> (-50%) ⬇️
...data-center/server/server-stand-actor.component.ts 50% <0%> (-50%) ⬇️
.../data-center/server/workstation-actor.component.ts 66.66% <0%> (-33.34%) ⬇️
...tft/src/lib/object/helper/axes-helper.component.ts 83.33% <0%> (-16.67%) ⬇️
...tft/src/lib/object/helper/grid-helper.component.ts 85.71% <0%> (-14.29%) ⬇️
...t/src/lib/object/loader/object-loader.component.ts 75% <0%> (-12.5%) ⬇️
...src/lib/object/light/hemisphere-light.component.ts 88.88% <0%> (-11.12%) ⬇️
...c/lib/object/connector/line-connector.component.ts 90% <0%> (-10%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308549a...090d61e. Read the comment docs.

@makimenko makimenko merged commit 0e7bb3d into master Jan 31, 2020
@makimenko makimenko deleted the angular-cli-9rc12 branch January 31, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant