Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add leftOrNull and rightOrNull Kotlin extensions #15

Closed
sdeleuze opened this issue May 6, 2019 · 2 comments
Closed

Add leftOrNull and rightOrNull Kotlin extensions #15

sdeleuze opened this issue May 6, 2019 · 2 comments
Labels
enhancement New feature or request kotlin release: 0.2.x

Comments

@sdeleuze
Copy link

sdeleuze commented May 6, 2019

Optional should be exposed as nullable in Kotlin, we use that pattern in Spring Data for example.
@making making closed this as completed in 9a984db May 6, 2019
@sdeleuze
Copy link
Author

sdeleuze commented May 6, 2019

Could you please make left and right package private in order to expose them directly via leftOrNull and rightOrNull without this wrapping / unwrapping unnecessary step? That will also be useful to access them from other extensions like #14.

@sdeleuze sdeleuze mentioned this issue May 6, 2019
Closed
@making
Copy link
Owner

making commented May 6, 2019

Oh, I see

making added a commit that referenced this issue May 6, 2019
@making
Make left/right field package private #15
d3b4573
@making making added enhancement New feature or request release: 0.2.x labels May 6, 2019
@making making added the kotlin label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request kotlin release: 0.2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@making @sdeleuze