Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support module-info.java #160

Open
making opened this issue Jul 14, 2021 · 2 comments
Open

Support module-info.java #160

making opened this issue Jul 14, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@making
Copy link
Owner

making commented Jul 14, 2021

https://github.com/moditect/moditect

@making making added the enhancement New feature or request label Jul 14, 2021
@making making added the help wanted Extra attention is needed label Oct 12, 2021
@duponter
Copy link
Contributor

There are several options to go forward with this. It depends on the choices you want to make.

Do you want to stay on JDK 8?

Do you want to upgrade to JDK 11?

  • Adding a module-info.java is the easiest way forward, but you'll probably lose JDK 8 compatibility.
  • If you'd like to keep JDK 8 compatibility, a multi-release jar might be a solution.

I do not have experience with the Moditect Maven plugin, but at first sight it seems especially handy to add module-info files to jar files you do not control.
Although, you can use this plugin in your codebase as well, but I think it is easier to add the module-info file directly.

Another consideration you have to make: Which packages do you want to export and which ones need to stay internal? This might imply that you need to move some functionality.

@making
Copy link
Owner Author

making commented Oct 13, 2021

Thanks for the write up!

Do you want to stay on JDK 8?

Yes. I will support Java 8 until YAVI 2.0.

At the moment, there are few packages that I want to be internal. I thought I'd have module-info for the future, but as you say, Automatic Module Name should be sufficient for now.
Leave this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants