Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using YAVI as a JPMS module generates warning during Maven build #171

Closed
duponter opened this issue Sep 30, 2021 · 2 comments
Closed

Using YAVI as a JPMS module generates warning during Maven build #171

duponter opened this issue Sep 30, 2021 · 2 comments
Milestone

Comments

@duponter
Copy link
Contributor

When using YAVI as a dependency in a JPMS compliant application, following warning is issued by Apache Maven 3.8.1 during compilation (using Java versions 11 and 17, vendor: Temurin)

[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ matis-infrastructure ---
[INFO] Required filename-based automodules detected: [yavi-0.8.3.jar]. Please don't publish this project to a public artifact repository!

Additionally to add the YAVI dependency in the project's pom file, an entry has to be added to the project's module-info.java.
requires yavi;

Issue #160 suggests that you're planning full module support in the future, it is fairly easy to prevent this warning while awaiting the actual module support.
It merely requires to add some manifest configuration to the default maven-jar-plugin configuration. (I will submit a PR very soon)
Following entry will be added to the generated manifest.mf: Automatic-Module-Name: am.ik.yavi
If preferred, another module name can be inserted here.

After applying these changes, the YAVI entry in module-info.java needs to be changed to:
requires am.ik.yavi;

@making
Copy link
Owner

making commented Sep 30, 2021

Fixed via gh-172

@making making closed this as completed Sep 30, 2021
@making making added this to the 0.9.0 milestone Oct 11, 2021
@making
Copy link
Owner

making commented Oct 12, 2021

@duponter If you are familiar with JPMS, I also welcome a PR for gh-160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants