Question about usage performance

[lonre]

builder.constraintOnTarget(param -> {
  Document doc = documentDao.findById(param.getId());
  if (isNull(doc)) {
    return false;
  }
  return true;
}, "id", "not_exists", "id not exists");

builder.constraintOnTarget(param -> {
  Document doc = documentDao.findById(param.getId());
  if (!param.getOwnerId().equals(doc.getOwnerId())) {
    return false;
  }
  return true;
}, "ownerId", "no_permission", "no permission");

this validator will execute documentDao.findById twice, is it possible to make the documentDao.findById execute only once?

Thanks

[making]

Unfortunately, YAVI does not support such cases.
As a workaround, you can define a validator for am.ik.yavi.fn.Pair

Example

Validator<Pair<Document, Param>> validator = ValidatorBuilder.<Pair<Document, Param>>of()
		.constraintOnObject(Pair::first, "id", c -> c.notNull().message("{0} not exists"))
		.constraintOnTarget(pair -> pair.first() == null || Objects.equals(pair.first().getOwnerId(), pair.second().getOwnerId()),
				"ownerId", "no_permission", "no permission")
		.build();


validator.validate(new Pair<>(documentDao.findById(param.getId()), param));

[lonre]

Unfortunately, YAVI does not support such cases.
As a workaround, you can define a validator for am.ik.yavi.fn.Pair

Example

Validator<Pair<Document, Param>> validator = ValidatorBuilder.<Pair<Document, Param>>of()
		.constraintOnObject(Pair::first, "id", c -> c.notNull().message("{0} not exists"))
		.constraintOnTarget(pair -> pair.first() == null || Objects.equals(pair.first().getOwnerId(), pair.second().getOwnerId()),
				"ownerId", "no_permission", "no permission")
		.build();


validator.validate(new Pair<>(documentDao.findById(param.getId()), param));

@making Thanks for your help.

but the full validator buider is

builder._string(Param::getFielda, "fielda", a -> a.notNull().notBlank());
builder._string(Param::getFieldb, "fieldb", a -> a.notNull().notBlank());
builder._long(Param::getId, "id", Constraint::notNull);
builder.constraintOnTarget(param -> {
  Document doc = documentDao.findById(param.getId());
  if (isNull(doc)) {
    return false;
  }
  return true;
}, "id", "not_exists", "id not exists");

builder.constraintOnTarget(param -> {
  Document doc = documentDao.findById(param.getId());
  if (!param.getOwnerId().equals(doc.getOwnerId())) {
    return false;
  }
  return true;
}, "ownerId", "no_permission", "no permission");

If there is some workaround please?

[making]

@lonre

Validator<Pair<Document, Param>> validator = new ValidatorBuilder<Pair<Document, Param>>("" /* message key separator */)
		.nest(Pair::second, "", b -> b
				.constraint(Param::getId, "id", c -> c.notNull())
				.constraint(Param::getFieldA, "fieldA", c -> c.notNull().notBlank())
				.constraint(Param::getFieldB, "fieldB", c -> c.notNull().notBlank()))
		.constraintOnObject(Pair::first, "id", c -> c.notNull().message("{0} not exists"))
		.constraintOnTarget(pair -> pair.first() == null || Objects.equals(pair.first().getOwnerId(), pair.second().getOwnerId()),
				"ownerId", "no_permission", "no permission")
		.build();

[lonre]

@lonre

Validator<Pair<Document, Param>> validator = new ValidatorBuilder<Pair<Document, Param>>("" /* message key separator */)
		.nest(Pair::second, "", b -> b
				.constraint(Param::getId, "id", c -> c.notNull())
				.constraint(Param::getFieldA, "fieldA", c -> c.notNull().notBlank())
				.constraint(Param::getFieldB, "fieldB", c -> c.notNull().notBlank()))
		.constraintOnObject(Pair::first, "id", c -> c.notNull().message("{0} not exists"))
		.constraintOnTarget(pair -> pair.first() == null || Objects.equals(pair.first().getOwnerId(), pair.second().getOwnerId()),
				"ownerId", "no_permission", "no permission")
		.build();

ok I see, Thanks for your help again @making

[lonre]

Hi @making

this is commons use cases in our projects, do you any idea or any plan to support this case

Thanks

[making]

It's hard to achieve it under the current design.

I would use caching like Spring Framework provides
https://spring.io/guides/gs/caching/

[lonre]

It's hard to achieve it under the current design.

I would use caching like Spring Framework provides
https://spring.io/guides/gs/caching/

Hi, Currently I am considering to fork yavi, and have a dirty hack. Extends ViolatedValue with specified violation details,

and hack the validate method, if ViolatedValue has details, use that, otherwise use original logic 😂

@making

[making]

Can you add test cases? I'm not sure what your commits want to achieve

[lonre]

Can you add test cases? I'm not sure what your commits want to achieve

Hi @making

test added

lonre@ccf8970

[making]

Sorry, but I can't accept your proposal.
Again, It's hard to achieve it under the current design.

It may require big changes to the code base

[lonre]

Sorry, but I can't accept your proposal.
Again, It's hard to achieve it under the current design.

It may require big changes to the code base

Hi @making

This make sense, and thanks for your time.

It is just dirty changes, and for my own usage.

[atkawa7]

@making Thanks for this library. I have been using yavi java-poet and jsonschema to create validators and this issue keeps on propping up. For example I have custom validators to validate phone numbers and jwt etc. However I have to parse the values twice one which I would discard and another which I would use because there is no caching on the return value.

[making]

@atkawa7 can you open a new issue? This is closed.
And please share a minimal reproducible working example to get the better context.

[atkawa7]

Thanks @making I have created a new ticket copying this one