Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Replacing Either with vavr's Either #26

Closed
making opened this issue Oct 1, 2019 · 2 comments
Closed

Consider Replacing Either with vavr's Either #26

making opened this issue Oct 1, 2019 · 2 comments
Labels
feedback required

Comments

@making
Copy link
Owner

making commented Oct 1, 2019

I'm considering to have Vavr as an optional dependency and use io.vavr.control.Either instead of am.ik.yavi.fn.Either. I'm not sure how many people use Vavr but having multiple Either implementation in a project would confuse those who want to use Vavr and YAVI.

Feedback is welcome.
@making making added enhancement New feature or request release: 0.3.x labels Oct 1, 2019
@making
Copy link
Owner Author

making commented Oct 2, 2019

For example, resilience4j pulls Vavr as a dependency

making added a commit that referenced this issue Jan 21, 2020
@making
Replace Either with vavr's Either as an optional dependency
5912db6 
fixes #26
@making making mentioned this issue Jan 21, 2020
Closed
@making making added feedback required and removed release: 0.3.x enhancement New feature or request labels Jan 25, 2020
@making
Copy link
Owner Author

making commented May 12, 2021

Vavr pulls not only Either but also a bunch of features that are too much for YAVI.
I'm going to keep own Either.

@making making closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Replace Either with vavr's Either as an optional dependency making/yavi
1 participant
@making