STYLE: Cxx11 modernization steps #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
66d7489 is incorrect. I understand why, and will try to submit a patch. Once done, please re-run your scripts. |
hjmjohnson
force-pushed
the
cxx11-modernization-steps
branch
from
c00aca5
to
42d71ba
Compare
|
@malaterre I have removed that patch from the list for now. I'm happy to re-run one task script, but re-running all the scripts is a bit tedious. |
|
I had an incorrect filter bug that missed all the header files for GDCM. I'm working through that now. |
hjmjohnson
force-pushed
the
cxx11-modernization-steps
branch
from
42d71ba
to
49e7025
Compare
hjmjohnson
changed the title
hjmjohnson
force-pushed
the
cxx11-modernization-steps
branch
2 times, most recently
from
7aedd65
to
6128aef
Compare
|
@malaterre I removed the offending patch set. Is there a problem with the reset of this? |
GDCM/Source/MediaStorageAndFileFormat/gdcmSerieHelper.h:96:17:
warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
typedef struct {
^
Rule
See: https://en.cppreference.com/w/cpp/language/typedef
Building CXX object Applications/Cxx/CMakeFiles/gdcmtar.dir/gdcmtar.cxx.o
GDCM/Applications/Cxx/gdcmtar.cxx:1395:13: warning: comparison of different enumeration types ('gdcm::UIDs::TSType' and 'gdcm::UIDs::TSName') [-Wenum-compare]
if( uid != gdcm::UIDs::EnhancedMRImageStorage )
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GDCM/Utilities/gdcmopenjpeg/src/lib/openjp2/tcd.c:2227:35:
warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-int-float-conversion]
if (l_value > INT_MAX) {
hjmjohnson
force-pushed
the
cxx11-modernization-steps
branch
from
6128aef
to
ebd3016
Compare
Find and remove redundant void argument lists.
The check converts the usage of null pointer constants (eg. NULL, 0) to
use the new C++11 nullptr keyword.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-nullptr -header-filter=.* -fix
Finds and replaces integer literals which are cast to bool.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-bool-literals -header-filter=.* -fix
hjmjohnson
force-pushed
the
cxx11-modernization-steps
branch
from
ebd3016
to
bf2020d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.