Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: compile with Visual Studio in conformance mode AKA /permissive- #74

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

dzenanz
Copy link
Contributor

@dzenanz dzenanz commented Dec 5, 2018

Upstreaming change from InsightSoftwareConsortium/ITK#261.

@hjmjohnson
Copy link
Contributor

@dzenanz Thanks for porting the ITK identified fix upstream.

@malaterre malaterre merged commit 7fe8917 into malaterre:master Dec 5, 2018
@malaterre
Copy link
Owner

@dzenanz I am getting confused...why is this patch only applying onto gdcm/master ? Did ITK recently moved onto gdcm from master ?

@dzenanz
Copy link
Contributor Author

dzenanz commented Dec 5, 2018

Periodically, we update versions of libraries bundled with ITK. The latest update of GDCM was via InsightSoftwareConsortium/ITK#264. And the script which does the updating targets release tag. It maybe falls back to master if there is no release tag?

@malaterre
Copy link
Owner

@dzenanz No everything is just fine. In fact it seems I never backported to release branch a patch you are using within ITK. Everything is fine, the script is working as expected. I am hoping to package the next release anyway from master real time soon.

@dzenanz
Copy link
Contributor Author

dzenanz commented Dec 5, 2018

Oh, you thought it would have made more sense to merge it into release branch? That's why I was confused by your confusion 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants