Always pass --lib to cargo with link-args #40
Conversation
Cargo will throw an error when the target of the compilation is ambiguous. This leads to an error when there's an additional main.rs, e.g. for easy testing during development. Specifying `--lib` makes it clear that we only want to build the library. Before ``` ~/.cargo/bin/cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup error: extra arguments to `rustc` can only be passed to one target, consider filtering ``` After ``` ~/.cargo/bin/cargo rustc --release --lib -- -C link-args=-Wl,-undefined,dynamic_lookup ```
| @@ -114,6 +114,7 @@ def cargo_rustc_args | |||
| args = [] | |||
| unless config.dynamic_linker_flags == '' || config.target_os == 'mingw32' | |||
| args.push( | |||
| '--lib', | |||
There was a problem hiding this comment.
Why isn't this outside of the conditional?
There was a problem hiding this comment.
cargo will only complain about this issue when handing additional flags to rustc. So it works just fine when no linker flags are passed.
|
I think this sort of bugfix needs a(n integration) regression test, but this project isn't particularly set up for that yet. I'll take suggestions on how to do it, though. |
|
Yes, I agree. One way would be to ship a minimal gem under |
|
Sorry for the extremely long delay! I appreciate the contribution. |
Cargo will throw an error when the target of the compilation is
ambiguous. This leads to an error when there's an additional main.rs,
e.g. for easy testing during development. Specifying
--libmakes itclear that we only want to build the library.
Before
After
Versions: