Glasgow - Class 06 - Malkit Benning - TV Show DOM Project #1
Conversation
basic start
css still to do
search working
added header to do - have page refresh properly
still to place tv shows in sorted order
with sorted tv shows
✅ Deploy Preview for cyf-malkitbenning-tv ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| font-family: 'Roboto', sans-serif; | ||
| } | ||
|
|
||
| .header-element{ |
There was a problem hiding this comment.
The CSS code is very readable and with small clearly named elements
| <link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400&family=Sorts+Mill+Goudy:ital@0;1&display=swap" rel="stylesheet"> | ||
| </head> | ||
|
|
||
| <body> |
There was a problem hiding this comment.
this is quite an amazing way to separate and make the code more modular. I was struggling with this part.
| @@ -0,0 +1,246 @@ | |||
| //You can edit ALL of the code here | |||
|
|
|||
| function fetchAndBuildEpisodes(tvShowNumber) { | |||
There was a problem hiding this comment.
Thos fetching function is written very well, it's easy to read and the functionality is very well written.
| episodesContainer.classList.add("episodes-container"); | ||
| showElem.appendChild(episodesContainer); | ||
|
|
||
| for (const [i, episode] of episodeList.entries()) { |
There was a problem hiding this comment.
All the parts of the code are written in smaller parts, I should start doing this in my code as well. Its easier to read.
| return lowerCaseGenres.includes(matchString); | ||
| } | ||
|
|
||
| function searchFilter(allShows) { |
There was a problem hiding this comment.
I was struggling with this search function you have writen it very smartly.
for review - I complete up to and including level 500