[#17] [API] As a User, I can sign up and sign in/out with a username and password #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
added
$user-login
malparty
changed the title
junan
reviewed
Jun 23, 2021
junan
reviewed
Jun 23, 2021
|
@malparty Last few minor comments, very close to approving it. :) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| include ErrorHandlerConcern | ||
|
|
||
| # Overridden from doorkeeper as the doorkeeper revoke action does not return response according to json-api spec | ||
| def revoke |
There was a problem hiding this comment.
| Remove unused methods (api::v1::tokenscontroller#revoke) |
| # The authorization server responds with HTTP status code 200 if the client | ||
| # submitted an invalid token or the token has been revoked successfully. | ||
| if token.blank? | ||
| render json: token_revoke_response, status: :ok |
There was a problem hiding this comment.
| Calls 'render json: token_revoke_response, status: :ok' 2 times |
| # of the error by the authorization server as described below. | ||
| elsif authorized? | ||
| revoke_token | ||
| render json: token_revoke_response, status: :ok |
There was a problem hiding this comment.
| Calls 'render json: token_revoke_response, status: :ok' 2 times |
| } | ||
| end | ||
|
|
||
| def token_revoke_response |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
ankitkalia1195
approved these changes
Jun 23, 2021
@junan, "Looks Good To Me" or "Let's Go To Merge"? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 [API] As a User, I can sign up and sign in/out with a username and password
What happened
Adding OAuth2 API to sign_in, sign_out and sign_up
Insight
Routes (all POST)
/api/v1/users=>Api::V1::UsersController/create/api/v1/oauth/token=>Doorkeeper::TokensController/create/api/v1/oauth/revoke=>Doorkeeper::TokensController/revoke/oauth/applications/=>Doorkeeper::ApplicationsController/indexProof Of Work
All 3 examples are available in the postman documentation (link available in the GitHub Wiki too)
Following @junan feedback, we now have Doorkeeper UI to manage apps: