Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-sef endpoint url generation #2

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

danyaPostfactum
Copy link
Contributor

Your plugin does not work correctly with disabled SEF links.
Url to "add" page is generated like http://site.com/?page_id=5&woo-walletadd/

Use wc_get_endpoint_url to pass a query var and generate correct url (both sef and non-sef)

@malsubrata
Copy link
Owner

@danyaPostfactum
Thanks for contributing to our GitHub repository. Yes you are right we should use wc_get_endpoint_url instead of wc_get_account_endpoint_url.

@malsubrata malsubrata closed this Mar 16, 2018
@malsubrata malsubrata reopened this Mar 16, 2018
@malsubrata malsubrata merged commit 4845eef into malsubrata:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants