Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request to source code #2

Open
mrkam2 opened this issue Nov 27, 2017 · 2 comments
Open

Pull Request to source code #2

mrkam2 opened this issue Nov 27, 2017 · 2 comments

Comments

@mrkam2
Copy link

mrkam2 commented Nov 27, 2017

What I was looking for is an extension that allows to jump from the PR comment to the corresponding line of the code (existing in the local repo, without any downloads). Is this something you can add?

@mamal72
Copy link
Owner

mamal72 commented Nov 27, 2017

Hi. Thanks for sharing your thoughts.

Hm... It seems a little tricky & not possible at the moment as the extension has no access to your local file system. It needs to know where you store your cloned projects to get access to them.
It's possible to implement download the repo and open that line in VSC but without downloading... Not now.
I think I can implement that too but it may take some time. It can be implemented by adding a settings page for the extension with a form for choosing root directory of cloned projects. This way, the extension can simply open that file in VSC. 🤔
I've not enough time to work on this for now. I may do it in the future (maybe next few weeks).
Anyway, PRs are all welcome! 🙏 👍 😁

@mrkam2
Copy link
Author

mrkam2 commented Nov 27, 2017

Yep, I was also thinking about settings page to set the root folder.

Seems like another missing feature is to work on a single line vs. full page.

Thanks for considering this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants