Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read repodata.json using nl::json (rerun) #2753

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Read repodata.json using nl::json (rerun) #2753

merged 5 commits into from
Oct 4, 2023

Conversation

AntoinePrv
Copy link
Member

Rerun #2688

@AntoinePrv AntoinePrv self-assigned this Aug 16, 2023
@AntoinePrv AntoinePrv force-pushed the repodata-json branch 2 times, most recently from 0950e46 to c5e3fe7 Compare August 16, 2023 10:24
@AntoinePrv AntoinePrv closed this Aug 16, 2023
@AntoinePrv AntoinePrv reopened this Aug 16, 2023
@AntoinePrv AntoinePrv mentioned this pull request Aug 16, 2023
Closed
@AntoinePrv AntoinePrv force-pushed the repodata-json branch 10 times, most recently from a9b088f to e81be9e Compare August 24, 2023 16:23
@AntoinePrv AntoinePrv force-pushed the repodata-json branch 2 times, most recently from 6e6d8ed to 81651a0 Compare August 31, 2023 17:17
@AntoinePrv
Copy link
Member Author

So this is still timing out... nlohmann json is too slow for our case.

@AntoinePrv AntoinePrv force-pushed the repodata-json branch 7 times, most recently from 7e2ffae to f3a9767 Compare September 12, 2023 16:40
@AntoinePrv AntoinePrv force-pushed the repodata-json branch 3 times, most recently from dbacaef to 3036111 Compare September 19, 2023 09:49
@AntoinePrv
Copy link
Member Author

AntoinePrv commented Sep 28, 2023 •
edited
Loading

In the end

  • Parsing directly from simdjson into libsolv (experimental, not activated by default).
  • Remove .solv file on windows since it is slower that parsing the json.

@AntoinePrv AntoinePrv force-pushed the repodata-json branch 2 times, most recently from 31e63f7 to 84ead0c Compare October 2, 2023 16:30
@AntoinePrv AntoinePrv marked this pull request as ready for review October 3, 2023 07:26
@AntoinePrv AntoinePrv merged commit 91b6c44 into mamba-org:main Oct 4, 2023
23 checks passed
@AntoinePrv AntoinePrv deleted the repodata-json branch October 4, 2023 20:06
@jaimergp jaimergp mentioned this pull request Jul 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees

@AntoinePrv AntoinePrv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoinePrv @JohanMabille