Allow defaults::* spec #2927
Merged
Allow defaults::* spec #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like it could be correct. We should know with a unit test :) |
|
Added a test. Ready for review again. |
jonashaag
approved these changes
Oct 23, 2023
|
Is there any chance you folks would accept a backport for the 1.x branch so we can get this out relatively soon? It would be awesome to have this fix for conda-libmamba-solver! |
|
IMO definitely yes! |
isuruf
added a commit
to isuruf/mamba
that referenced
this pull request
Oct 25, 2023
JohanMabille
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Allow defaults::* spec (#2927) * return architecture levels for micromamba (#2921) * return architecture levels for micromamba * fix formatting * use function multiversioning only on x86 * fix formatting * update test * use __builtin_cpu_supports and check for more features Co-authored-by: Marcel Bargull <mbargull@users.noreply.github.com> --------- Co-authored-by: Marcel Bargull <mbargull@users.noreply.github.com> * Fix channels with slashes regression (#2926) * Fix channels with slashes regression * fix formatting * make the test isolated Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> * Add more tests * Use pytest utilities for negative testing * Add extra test doc --------- Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> * Fix for name change --------- Co-authored-by: Marcel Bargull <mbargull@users.noreply.github.com> Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431
I'm not sure if this is the best way to fix this. Let me know what your thoughts are.
cc @jonashaag @AntoinePrv @jaimergp