Allow deleting channel members and changing role of existing members #495
Conversation
janjagusch
changed the title
quetz/main.py
Outdated
| status_code=status.HTTP_409_CONFLICT, | ||
| detail=f"Member {new_member.username} in {channel.name} exists", | ||
| status_code=status.HTTP_404_NOT_FOUND, | ||
| detail=f"channel member {username}/{channel.name} not found", |
There was a problem hiding this comment.
Maybe it would be clearer to write "User {username} does not exist or is not a member of {channel.name}" or something along those lines?
There was a problem hiding this comment.
Sure! I'll go ahead and adjust it. In fact, I can add a separate check to determine whether the user exists.
There was a problem hiding this comment.
should be good now
|
This looks good to me. Let me know what you think about my comment. Are you OK if I squash the commits when merging? Or do you want to clean up the history? |
Great!
I've incorporated your comment.
Totally fine with squashing. Sorry about the commit mess, I think I was debugging against CI at some point. |
|
I'll merge after CI passes! |
Nice! Apparently, there are some more CI issues, which also seem to occur on Should be unrelated to this PR then, right? |
Closes #494
post_channel_memberfunction to work for new and already existing channel members.delete_channel_memberfunction and added to REST API.Noneinrest_models.Memberclass (this can otherwise cause nasty internal server errors when listing channel members withNoneas role).CI running here. I believe the test failure is unrelated to these changes.