Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SQL authenticator plugin to own repo #593

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

simonbohnen
Copy link
Collaborator

@simonbohnen simonbohnen commented Feb 9, 2023

Deletes the quetz-sql-authenticator from this repo and moves it to https://github.com/mamba-org/quetz-sql-authenticator.

See #567.

@simonbohnen simonbohnen added the enhancement New feature or request label Feb 9, 2023
@janjagusch
Copy link
Collaborator

Nice! Let's merge this once quetz-sql-authenticator is on Conda-Forge (conda-forge/staged-recipes#22038 (review)).

@janjagusch janjagusch closed this Feb 16, 2023
@janjagusch janjagusch reopened this Feb 16, 2023
@janjagusch janjagusch added maintenance and removed enhancement New feature or request labels Feb 16, 2023
@janjagusch
Copy link
Collaborator

janjagusch commented Feb 18, 2023

@simonbohnen, could you please rebase main? Then we can merge this PR. :)

Also, should we still reference the SQL authenticator somewhere in the quetz documentation?

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Base: 82.46% // Head: 81.59% // Decreases project coverage by -0.88% ⚠️

Coverage data is based on head (228ef9e) compared to base (4317976).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   82.46%   81.59%   -0.88%     
==========================================
  Files          78       78              
  Lines        6084     6084              
==========================================
- Hits         5017     4964      -53     
- Misses       1067     1120      +53     
Impacted Files Coverage Δ
quetz/pkgstores.py 42.73% <0.00%> (-11.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen marked this pull request as ready for review February 19, 2023 16:53
README.md Outdated
Comment on lines 32 to 48
### Table of Contents

- [Usage](#usage)
- [S3 Backend](#s3-backend)
- [Google OAuth 2.0 OpenID Connect](#google-oauth-20-openid-connect)
- [PostgreSQL](#postgresql)
- [Running PostgreSQL server with docker](#running-postgresql-server-with-docker)
- [Deploying Quetz with PostgreSQL backend](#deploying-quetz-with-postgresql-backend)
- [Running tests with PostgreSQL backend](#running-tests-with-postgresql-backend)
- [Frontend](#frontend)
- [Using quetz](#using-quetz)
- [Create a channel](#create-a-channel)
- [Generate an API key](#generate-an-api-key)
- [Create a proxy channel](#create-a-proxy-channel)
- [Create a mirroring channel](#create-a-mirroring-channel)
- [Plugins](#plugins)
- [License](#license)
Copy link
Collaborator

@janjagusch janjagusch Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we auto-generate this? Otherwise, maybe remove it, as it will eventually get out of sync.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah would agree, i'll remove it. The readme is getting kinda long anyways

Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question about ToC, then let's merge. 👍

Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the license section back in and merge. 👍

Comment on lines -229 to -234
## License

We use a shared copyright model that enables all contributors to maintain the copyright on their contributions.

This software is licensed under the BSD-3-Clause license. See the [LICENSE](LICENSE) file for details.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the license section?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to the bottom, I think it didn't fit where it was. But i'm also fine with putting it back

@janjagusch janjagusch merged commit 8073e2b into mamba-org:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants