-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SQL authenticator plugin to own repo #593
Move SQL authenticator plugin to own repo #593
Conversation
Nice! Let's merge this once |
@simonbohnen, could you please rebase main? Then we can merge this PR. :) Also, should we still reference the SQL authenticator somewhere in the quetz documentation? |
ac2e6f6
to
3838697
Compare
Codecov ReportBase: 82.46% // Head: 81.59% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 82.46% 81.59% -0.88%
==========================================
Files 78 78
Lines 6084 6084
==========================================
- Hits 5017 4964 -53
- Misses 1067 1120 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
README.md
Outdated
### Table of Contents | ||
|
||
- [Usage](#usage) | ||
- [S3 Backend](#s3-backend) | ||
- [Google OAuth 2.0 OpenID Connect](#google-oauth-20-openid-connect) | ||
- [PostgreSQL](#postgresql) | ||
- [Running PostgreSQL server with docker](#running-postgresql-server-with-docker) | ||
- [Deploying Quetz with PostgreSQL backend](#deploying-quetz-with-postgresql-backend) | ||
- [Running tests with PostgreSQL backend](#running-tests-with-postgresql-backend) | ||
- [Frontend](#frontend) | ||
- [Using quetz](#using-quetz) | ||
- [Create a channel](#create-a-channel) | ||
- [Generate an API key](#generate-an-api-key) | ||
- [Create a proxy channel](#create-a-proxy-channel) | ||
- [Create a mirroring channel](#create-a-mirroring-channel) | ||
- [Plugins](#plugins) | ||
- [License](#license) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we auto-generate this? Otherwise, maybe remove it, as it will eventually get out of sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah would agree, i'll remove it. The readme is getting kinda long anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question about ToC, then let's merge. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the license section back in and merge. 👍
## License | ||
|
||
We use a shared copyright model that enables all contributors to maintain the copyright on their contributions. | ||
|
||
This software is licensed under the BSD-3-Clause license. See the [LICENSE](LICENSE) file for details. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the license section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to the bottom, I think it didn't fit where it was. But i'm also fine with putting it back
Deletes the
quetz-sql-authenticator
from this repo and moves it to https://github.com/mamba-org/quetz-sql-authenticator.See #567.