-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check-release action to v2 #601
Conversation
Codecov ReportBase: 82.51% // Head: 82.49% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.02%
==========================================
Files 78 78
Lines 6063 6068 +5
==========================================
+ Hits 5003 5006 +3
- Misses 1060 1062 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Instead of moving the Alembic migration files outside the package, we should ignore the |
Releasing a new version with jupyter-releaser currently fails:
We didn't catch this because we're using an old version of the jupyter-releaser GitHub action.
In this PR, we do three things:
check-python
step succeed by ignore theW004
check incheck-wheel-contents
(as recommended for Alembic migration files, details here)I also added
pre-commit
andjupyter-releaser
as dependencies to the environment file.