Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-release action to v2 #601

Merged
merged 16 commits into from
Feb 16, 2023
Merged

Conversation

janjagusch
Copy link
Collaborator

@janjagusch janjagusch commented Feb 15, 2023

Releasing a new version with jupyter-releaser currently fails:

dist/quetz_server-0.5.1-py2.py3-none-any.whl: W004: Module is not located at importable path:
  quetz/migrations/versions/0653794b6252_adding_url_and_platforms_dirs.py
  quetz/migrations/versions/0a0ab48887ab_adding_function_args_to_job_spec.py
  quetz/migrations/versions/[302](https://github.com/janjagusch/jupyter_releaser/actions/runs/4185520217/jobs/7252691803#step:5:305)41b33d849_add_task_pending_state.py
  quetz/migrations/versions/[303](https://github.com/janjagusch/jupyter_releaser/actions/runs/4185520217/jobs/7252691803#step:5:306)ff70c27fc_configure_mirror_endpoints.py
  quetz/migrations/versions/3c3288034362_add_channel_metadata.py
  quetz/migrations/versions/53f81aba78ce_use_biginteger_for_size.py
  quetz/migrations/versions/794249a0b1bd_adding_jobs_tables.py
  quetz/migrations/versions/8d1e9a9e0b1f_adding_download_metrics.py
  quetz/migrations/versions/8dfb7c4bfbd7_new_package_versions.py
  quetz/migrations/versions/98c04a65df4a_register_mirrors.py
  quetz/tests/data/dummy-plugin/quetz_dummyplugin/jobs.py

We didn't catch this because we're using an old version of the jupyter-releaser GitHub action.

In this PR, we do three things:

  • We bump the jupyter-releaser action to v2
  • We ensure that the jupyter-releaser action uses the current branch (and not the default branch)
  • We make the check-python step succeed by ignore the W004 check in check-wheel-contents (as recommended for Alembic migration files, details here)

I also added pre-commit and jupyter-releaser as dependencies to the environment file.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 82.51% // Head: 82.49% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e98dab6) compared to base (c0e3e2f).
Patch coverage: 87.50% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   82.51%   82.49%   -0.02%     
==========================================
  Files          78       78              
  Lines        6063     6068       +5     
==========================================
+ Hits         5003     5006       +3     
- Misses       1060     1062       +2     
Impacted Files Coverage Δ
quetz/db_models.py 95.78% <75.00%> (-1.12%) ⬇️
quetz/dao.py 89.16% <100.00%> (ø)
quetz/migrations/env.py 69.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janjagusch
Copy link
Collaborator Author

janjagusch commented Feb 15, 2023

Instead of moving the Alembic migration files outside the package, we should ignore the check-wheel-contents error (see here for details). Moving the tests outside the package seems reasonable, though.

@janjagusch janjagusch marked this pull request as ready for review February 16, 2023 08:00
@janjagusch janjagusch merged commit 822c924 into main Feb 16, 2023
@ivergara ivergara deleted the add-jupyter-releaser-checks branch June 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants