Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepoData, deserialize into a Sha256Hash / Md5Hash instead of String #139

Closed
wolfv opened this issue Mar 30, 2023 · 0 comments · Fixed by #153
Closed

RepoData, deserialize into a Sha256Hash / Md5Hash instead of String #139

wolfv opened this issue Mar 30, 2023 · 0 comments · Fixed by #153
Labels
good first issue Good for newcomers

Comments

@wolfv
Copy link
Contributor

wolfv commented Mar 30, 2023

We currently keep the hashes as String, but it would be nice for type safety to deserialize them into proper types. We have the rattler_digest::Sha256Hash and Md5Hash now that serve this purpose in PathsJson.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use digest in repodata baszalmstra/rattler
2 participants
@wolfv @baszalmstra