Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement build string version comparison #96

Closed
baszalmstra opened this issue Mar 6, 2023 · 5 comments
Closed

Implement build string version comparison #96

baszalmstra opened this issue Mar 6, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@baszalmstra
Copy link
Collaborator

baszalmstra commented Mar 6, 2023

Our matchspec implementation currently doesn't implement build string version comparison like >6 in python 3.9.3[build_number=">6"].

This would be a nice addition!

Conda implementation: https://github.com/conda/conda/blob/main/conda/models/version.py#L613

@baszalmstra baszalmstra added the good first issue Good for newcomers label Mar 6, 2023
@YeungOnion
Copy link
Contributor

Is this still needed? I'd like to take a look.

Additionally, the link is to main branch instead of commit hash, so to make sure, are you referring to the method below?

BuildNumberMatch.get_matcher

Anything else to know?

@baszalmstra
Copy link
Collaborator Author

Yes this is still needed! :)

Indeed, the link should point to the BuildNumberMatch class.

@YeungOnion
Copy link
Contributor

Thoughts on new dependency for more general version matching? Seems well established and has no depends. Might mess around with it for fun.

@baszalmstra
Copy link
Collaborator Author

Conda version parsing and ordering is very specific. I doubt the approach used by that crate will provide the correct result.

@baszalmstra
Copy link
Collaborator Author

Implemented in #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants