fix: result grouped by subdir instead of channel #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
approved these changes
May 21, 2024
|
small idea- can we change the error type ( or improve it ) so the next time it is propagate to the upstream libs ( pixi ) and we could output it? |
|
Yeah that could work as well! Rhe error originates from passing duplicate filenames to the solver that arent actually unique. This is a user error so we could also return an error. |
This was referenced May 22, 2024
Closed
Closed
Closed
Merged
baszalmstra
added a commit
that referenced
this pull request
May 27, 2024
## 🤖 New release * `rattler`: 0.25.0 -> 0.26.0 * `rattler_conda_types`: 0.23.1 -> 0.24.0 * `rattler_package_streaming`: 0.20.10 -> 0.21.0 * `rattler_networking`: 0.20.7 -> 0.20.8 * `rattler_lock`: 0.22.7 -> 0.22.8 * `rattler_repodata_gateway`: 0.20.1 -> 0.20.2 * `rattler_solve`: 0.22.0 -> 0.23.0 * `rattler_index`: 0.19.12 -> 0.19.13 * `rattler_shell`: 0.20.4 -> 0.20.5 * `rattler_virtual_packages`: 0.19.11 -> 0.19.12 <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler` <blockquote> ## [0.26.0](rattler-v0.25.0...rattler-v0.26.0) - 2024-05-27 ### Fixed - improve progress bar duration display ([#680](#680)) ### Other - introducing the installer ([#664](#664)) - create directories up front ([#533](#533)) </blockquote> ## `rattler_conda_types` <blockquote> ## [0.24.0](rattler_conda_types-v0.23.1...rattler_conda_types-v0.24.0) - 2024-05-27 ### Added - removed Ord and more ([#673](#673)) - always store purls as a key in lock file ([#669](#669)) - add solve strategies ([#660](#660)) ### Fixed - make topological sorting support fully cyclic dependencies ([#678](#678)) </blockquote> ## `rattler_package_streaming` <blockquote> ## [0.21.0](rattler_package_streaming-v0.20.10...rattler_package_streaming-v0.21.0) - 2024-05-27 ### Other - introducing the installer ([#664](#664)) </blockquote> ## `rattler_networking` <blockquote> ## [0.20.8](rattler_networking-v0.20.7...rattler_networking-v0.20.8) - 2024-05-27 ### Other - introducing the installer ([#664](#664)) </blockquote> ## `rattler_lock` <blockquote> ## [0.22.8](rattler_lock-v0.22.7...rattler_lock-v0.22.8) - 2024-05-27 ### Added - removed Ord and more ([#673](#673)) - always store purls as a key in lock file ([#669](#669)) </blockquote> ## `rattler_repodata_gateway` <blockquote> ## [0.20.2](rattler_repodata_gateway-v0.20.1...rattler_repodata_gateway-v0.20.2) - 2024-05-27 ### Fixed - result grouped by subdir instead of channel ([#666](#666)) ### Other - introducing the installer ([#664](#664)) </blockquote> ## `rattler_solve` <blockquote> ## [0.23.0](rattler_solve-v0.22.0...rattler_solve-v0.23.0) - 2024-05-27 ### Added - removed Ord and more ([#673](#673)) - always store purls as a key in lock file ([#669](#669)) - add solve strategies ([#660](#660)) ### Fixed - result grouped by subdir instead of channel ([#666](#666)) ### Other - introducing the installer ([#664](#664)) </blockquote> ## `rattler_index` <blockquote> ## [0.19.13](rattler_index-v0.19.12...rattler_index-v0.19.13) - 2024-05-27 ### Added - always store purls as a key in lock file ([#669](#669)) </blockquote> ## `rattler_shell` <blockquote> ## [0.20.5](rattler_shell-v0.20.4...rattler_shell-v0.20.5) - 2024-05-27 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_virtual_packages` <blockquote> ## [0.19.12](rattler_virtual_packages-v0.19.11...rattler_virtual_packages-v0.19.12) - 2024-05-27 ### Other - updated the following local packages: rattler_conda_types </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with duplicate records in the solver.