technos/ddragon.cpp: Added Double Dragon II layer priority PROM to clones #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelosa
requested changes
Jan 4, 2023
cuavas
changed the title
What do you mean by this? Have you confirmed that a PROM with the same contents is present on original boards for the clone versions? Or did you convert a board to the clone version and confirm that it works with the same priority PROM? In the latter case, these should really still be marked as bad dumps as they haven’t been confirmed on original boards. |
…m that specific board
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double Dragon II clones (and alternate versions) are missing one of the PROMs in the ROM section. I have checked that the systems work correctly using the same dump as in ddragon2.
In this commit, I have added that PROM to the ROM section. This matches what other drivers do in these circumstances. The comments suggest that a better dump may exist (although I doubt it).