Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TMS9995 Breadboard driver to evmbug.cpp #9370

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

cpswan
Copy link
Contributor

@cpswan cpswan commented Mar 5, 2022

Driver for Stuart Conner's TMS9995 Breadboard system supporting the full selection of ROMs

Also changed ROM config for the underlying TMAM6095 system as it uses a 4K ROM for u8 as and a 2K for u9.

I can run HELLO WORLD on the TMAM6095, so removed MACHINE_NOT_WORKING

evmbug_hello

Comment on lines 63 to 74
class tms9995bb_state : public evmbug_state
{
public:
tms9995bb_state(const machine_config &mconfig, device_type type, const char *tag)
: evmbug_state(mconfig, type, tag)
{ }

void tms9995bb(machine_config &config);

protected:
void mem_map(address_map &map);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually need an extra state class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the only way of doing the different memory map, but happy to take an alternative approach if you can point me in the right direction?

Copy link
Contributor Author

@cpswan cpswan Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I think I figured it out by looking at the bbc driver, hence 6d7c3db

Comment on lines 189 to 202
ROM_SYSTEM_BIOS( 0, "evmbug", "EVMBUG system monitor")
ROMX_LOAD( "evmbug.bin", 0x0000, 0x8000, CRC(a239ec56) SHA1(65b500d7d0f897ce0c320cf3ec32ff4042774599), ROM_BIOS(0) )
ROM_SYSTEM_BIOS( 1, "basicram", "EVMBUG system monitor and BASIC in RAM")
ROMX_LOAD( "basicram.bin", 0x0000, 0x8000, CRC(6ed5aba3) SHA1(76e0e39c0c0028efca339fb3cebaf42351fadb94), ROM_BIOS(1) )
ROM_SYSTEM_BIOS( 2, "basicrom", "EVMBUG system monitor and BASIC in ROM")
ROMX_LOAD( "basicram.bin", 0x0000, 0x8000, CRC(ded6350b) SHA1(83cf64834e59e216a91065c01ec91be1e10e7244), ROM_BIOS(2) )
ROM_SYSTEM_BIOS( 3, "forth", "EVMBUG system monitor and Forth")
ROMX_LOAD( "forth.bin", 0x0000, 0x8000, CRC(eee8f390) SHA1(59fc2a23c9ac52dce09a519c784db378782242b1), ROM_BIOS(3) )
ROM_SYSTEM_BIOS( 4, "test1", "Test EPROM 1")
ROMX_LOAD( "test1.bin", 0x0000, 0x8000, CRC(9b110ffb) SHA1(58ee990fb17822a879442b98f1b78ccf86b79f00), ROM_BIOS(4) )
ROM_SYSTEM_BIOS( 5, "test2", "Test EPROM 2")
ROMX_LOAD( "test2.bin", 0x0000, 0x8000, CRC(e7a7832d) SHA1(aa8c29097033804d1a0abf2af7cd846edfbd71a3), ROM_BIOS(5) )
ROM_SYSTEM_BIOS( 6, "test3", "Test EPROM 3")
ROMX_LOAD( "test3.bin", 0x0000, 0x8000, CRC(a28579eb) SHA1(477f853970f132592714bcdd048ec932e96c8593), ROM_BIOS(6) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’ve got mixed space and tab indentation here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by 37f8602

@cpswan
Copy link
Contributor Author

cpswan commented Mar 11, 2022

@cuavas the issues you brought up have been dealt with. What else needs to happen for this one?

@happppp
Copy link
Member

happppp commented Mar 11, 2022

Can you get rid of that rom link in the source code?
Why did you change private: to protected:?

See this link on how to submit the added dumps if you hadn't already done so:
https://wiki.mamedev.org/index.php?title=Submitting_Source_Code

@cpswan
Copy link
Contributor Author

cpswan commented Mar 11, 2022

@happppp

Can you get rid of that rom link in the source code? Why did you change private: to protected:?

Done with a53f44f

FWIW the shift from private to protected happened when I was using a sub-class, but that went with 6d7c3db

See this link on how to submit the added dumps if you hadn't already done so: https://wiki.mamedev.org/index.php?title=Submitting_Source_Code

I'll take care of that (for this and #9350).

@happppp
Copy link
Member

happppp commented Mar 11, 2022

Also, not really related to your PR contents.
In your opinion, is "evmbug" a poorly named romset? It is the name of the program, not of the hardware. Is "tmam6095" better? If so, can you rename it?
Oh, and there should be a space between TMAM and 6095 in the fullname.

@cpswan
Copy link
Contributor Author

cpswan commented Mar 11, 2022

The TMAM 6095 ROMs contain the "evmbug" monitor, so it's not a terrible name for the romset, but the driver should probably have been called tmam6095.cpp

It's possible that there are other ROMs out there that can go into the TMAM 6095 (though maybe unlikely, as collectors like Stuart would already have catalogued them). So if they were to crop up they could be added as further options/

@happppp happppp merged commit f4b7a31 into mamedev:master Mar 11, 2022
wilbertpol pushed a commit to wilbertpol/mame that referenced this pull request Apr 22, 2022
Add TMS9995 Breadboard driver. Also changed ROM config for the underlying TMAM6095 system as it uses a 4K ROM for u8 as and a 2K for u9.

New working machines added
----------
TMS9995 breadboard [Chris Swan]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants