Add Tibber energy price source #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
Signed-off-by: Stefan Rubner <stefan@whocares.de>
|
Hi, thanks for your contribution. I'm still think whether it is a good idea to merge this PR. The reason is that I can't maintain the code as I don't have a Tibber account. |
|
You don't need an account. You can find the official demo token in line 63 of the |
|
Oh, and of course if need be, I'd do the maintenance. |
|
Ok, then I will merge it (into development branch first). I want to add some breaking changes before I will release a new version=. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Tibber as the source of electricity prices. You need to have an account with Tibber and you also need to get an access token for their API from https://developer.tibber.com
Motivation:
I thought it'd be nice to be able to
Minor issue
I found no easy way to disable the configuration of
tax,percentage surchargeandabsolute surcharge. Those aren't needed for Tibber since they already provide net prices for the current customer as identified through the API token. If given, those values are silently ignored for Tibber.