Fixed aggregation on sparse grouping columns #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
sparse_aggregation
branch
from
e4da02f
to
401bd18
Compare
jjerphan
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Thank you, @JohanMabille.
LGTM modulo a few comment.
Here are some comments. I think I would wait for someone else's approval before pursuing, because I do not have yet an entire comprehensive knowledge of Column's internals.
Also, is there a non-regression test we could craft for #528?
| { | ||
| iter = std::make_optional(input_data.bit_vector()->first()); | ||
| // We use 0 for the missing value group id | ||
| next_group_id++; |
There was a problem hiding this comment.
This LGTM, but I cannot tell if this can invalidate some potential implicit invariant the aggregation clause or its tests might have been relying one.
JohanMabille
force-pushed
the
sparse_aggregation
branch
from
e60a987
to
1b6d3d1
Compare
jjerphan
reviewed
Nov 20, 2023
JohanMabille
force-pushed
the
sparse_aggregation
branch
3 times, most recently
from
d5bc06b
to
ae94957
Compare
jjerphan
approved these changes
Nov 21, 2023
willdealtry
approved these changes
Nov 21, 2023
cpp/arcticdb/processing/clause.cpp
Outdated
| @@ -304,6 +304,20 @@ Composite<ProcessingUnit> AggregationClause::process(std::shared_ptr<Store> stor | |||
| // 11.01 seconds with caching | |||
| // Not worth worrying about right now | |||
| robin_hood::unordered_flat_map<RawType, size_t> offset_to_group; | |||
|
|
|||
| bool is_sparse = col.column_->is_sparse(); | |||
There was a problem hiding this comment.
Could be const, although I suspect it won't make a lot of difference
JohanMabille
force-pushed
the
sparse_aggregation
branch
from
ae94957
to
51f928e
Compare
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
JohanMabille
force-pushed
the
sparse_aggregation
branch
from
51f928e
to
6941e7f
Compare
|
Sparsy Sparsy Sparsy me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Second part of #1007
Fixes #528
What does this implement or fix?
Any other comments?
mark_absent_rowson the grouping column, which is fragile. More generally, Column constructors should force the user to pass the size of the column for sparse columns.Checklist
Checklist for code changes...