maint: Remove use of folly/system/ThreadName.h #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
jjerphan
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
LGTM. Thank you, @ianthomas23.
I am not sure whether Remotery should be kept: is it still used?
Signed-off-by: Ian Thomas <ianthomas23@gmail.com>
ianthomas23
force-pushed
the
ianthomas23/remove_folly_threadname
branch
from
546896f
to
32a6ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes one item of the folly replacement plan, issue #1412.
What does this implement or fix?
This removes use of
folly/system/ThreadName.h. It was used in two places to obtain astd::stringname of a thread, and here is replaced with conversion of unique thread ID to a string usingfmtviaAny other comments?
This is used in two places, the first in the termination handler in
python_module.cppwhich I have manually tested. The second use is in the Remotery which, as far as I can tell, is not tested in CI so I am not sure of the status of the Remotery support.