Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct last_update_time type hint #1573

Merged
merged 1 commit into from
May 17, 2024
Merged

Correct last_update_time type hint #1573

merged 1 commit into from
May 17, 2024

Conversation

jamesmunro
Copy link
Collaborator

What does this implement or fix?

SymbolDescription.last_update_time is a pandas._libs.tslibs.timestamps.Timestamp which is a datetime.datetime subtype, not a numpy.datetime64.

Any other comments?

Should this be Union[datetime.datetime, numpy.datetime64]?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jamesmunro jamesmunro merged commit cd632fc into master May 17, 2024
107 checks passed
@jamesmunro jamesmunro deleted the bug/last-update-time-type branch May 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 alexowens90 approved these changes

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmunro @alexowens90