Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume fast tombstone is true and fix bug in VersionMapImpl::follow_version_chain #366

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Assume fast tombstone is true and fix bug in VersionMapImpl::follow_version_chain #366

merged 6 commits into from
Jun 9, 2023

Commits on Jun 8, 2023

  1. Assume fast tombstone is true. 

    Remove all branches involving fast tombstone property assuming it's
always true.
    @vasil-pashov
    Vasil Pashov authored and vasil-pashov committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    66b2f93 View commit details
    Browse the repository at this point in the history

  2. Remove rapidchecks for fast tombstone all

    @vasil-pashov
    Vasil Pashov authored and vasil-pashov committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    171e07e View commit details
    Browse the repository at this point in the history

  3. Fix prune_previous versions to no throw exception when there is an ex… 

    …isting symbol with no active versions. Now it throws only if the symbol does not exist.
    @vasil-pashov
    Vasil Pashov authored and vasil-pashov committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9792020 View commit details
    Browse the repository at this point in the history

  4. Fix VersionMapImpl::follow_version_chain so that it does not stop when 

    the first tombstone_all key is reached. We may have tombstone_all key
which deletes versions way down on the chain. Instead we should stop
when the current key version is <= tombstone_all version.
    @vasil-pashov
    Vasil Pashov authored and vasil-pashov committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4abbc96 View commit details
    Browse the repository at this point in the history

  5. Address review comments: 

    * Improve debug logging
* Remove unit test
    Vasil Pashov authored and Vasil Pashov committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    06999e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'master' into refactor-fast-tombstone

    @vasil-pashov
    vasil-pashov authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8565097 View commit details
    Browse the repository at this point in the history