Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for QEMU #298

Merged
merged 9 commits into from
Aug 27, 2021
Merged

Improvements for QEMU #298

merged 9 commits into from
Aug 27, 2021

Conversation

qookei
Copy link
Member

@qookei qookei commented Aug 11, 2021 •
edited by Geertiebear
Loading

Depends on managarm/managarm#388. Closes #101 and #256.

@qookei qookei mentioned this pull request Aug 11, 2021
Merged
@Dennisbonke Dennisbonke mentioned this pull request Aug 12, 2021
Merged
Geertiebear
Geertiebear reviewed Aug 14, 2021
View reviewed changes
Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be good to have, for example for the new pthread features, and maybe also the signal features if it isn't too much work.

options/posix/generic/posix_signal.cpp Outdated Show resolved Hide resolved
@qookei qookei force-pushed the master branch 4 times, most recently from d7cf377 to 9f91122 Compare August 21, 2021 02:24
Geertiebear
Geertiebear reviewed Aug 21, 2021
View reviewed changes
Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one comment.

options/posix/generic/pthread-stubs.cpp Outdated Show resolved Hide resolved
Geertiebear
Geertiebear approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, although the bug with the looping cancel handler should still be investigated further I think.

@Geertiebear Geertiebear merged commit 471b856 into managarm:master Aug 27, 2021
@Geertiebear Geertiebear mentioned this pull request Aug 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geertiebear Geertiebear Geertiebear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pthread_atfork() unimplemented
2 participants
@qookei @Geertiebear