-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abis: deprecate some headers in the mlibc ABI #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Andy-Python-Programmer @mintsuki @streaksu @fido2020 @Menotdan We're planning on deprecating some parts of the mlibc ABI: the
Note that these changes will be applied to the abi-break branch, and won't come into effect until the next ABI-breaking release. You are of course free to use whichever ABI you want. Please could you indicate (via thumbs up/down reaction or comment) whether you would like your sysdeps to have those headers switched over to the Linux ABI, or not? (and if yes, I'll add a commit to this PR doing so) |
718d4a3
to
befe55f
Compare
This reverts commit 8714dea.
I'm going to merge this (tomorrow), but the offer is still open. |
Sorry for the late reply!
Since its the above mlibc ABI headers are deprecated, updating the Aero sysdeps to use the Linux ABI headers for the above seems a considerable option. Considering that the Linux ABI headers are more stable and wont require many ABI-breaks in future (if any). So its a yes for switching the Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to merge this now, sysdeps have been given enough notice and the aero
sysdeps have been changed.
As discussed on Discord. This deprecates some headers in the
mlibc
ABI in favour of the Linux ABI. This partially reverts #580 (a deprecation notice is added instead).Once we are happy with this PR, we should ping all the sysdep owners to see if they are happy to have their sysdeps moved over to the Linux ABI too, because these changes will require some modifications to their kernels.
Fixes #430, fixes #257, fixes #466.