Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options/{internal,rtdl}: add GlobalConfig and RtdlConfig #650

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

64
Copy link
Member

@64 64 commented Jul 6, 2022

This PR adds a mechanism to pass global program configuration data between ld.so and libc.so, laying the groundwork for #614.

@64
Copy link
Member Author

64 commented Jul 7, 2022

ABI checker fails because I've removed __dlapi_secure_required, but that's in ld.so and shouldn't be an issue.

options/internal/include/mlibc/global-config.hpp Outdated Show resolved Hide resolved
options/rtdl/generic/main.cpp Outdated Show resolved Hide resolved
@64 64 marked this pull request as draft July 7, 2022 19:58
@64 64 changed the title options/{internal,rtdl}: add GlobalConfig options/{internal,rtdl}: add GlobalConfig and RtdlConfig Jul 7, 2022
@64 64 force-pushed the global-config branch 2 times, most recently from 04382d2 to b8c4350 Compare July 7, 2022 20:01
options/internal/include/mlibc/global-config.hpp Outdated Show resolved Hide resolved
options/internal/generic/global-config.cpp Outdated Show resolved Hide resolved
options/internal/generic/global-config.cpp Show resolved Hide resolved
@64 64 marked this pull request as ready for review July 7, 2022 23:42
Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR look good as it is now, and it seems as though all of @avdgrinten's comments have been covered.

@Geertiebear Geertiebear merged commit 44c38c8 into managarm:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants