Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFS: part 13, implement freopen #837

Merged
merged 4 commits into from
Apr 11, 2023
Merged

LFS: part 13, implement freopen #837

merged 4 commits into from
Apr 11, 2023

Conversation

no92
Copy link
Member

@no92 no92 commented Apr 7, 2023

No description provided.

Dennisbonke
Dennisbonke approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Geertiebear
Geertiebear approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Geertiebear Geertiebear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Make sure to add an issue for the freopen thing.

@no92 no92 mentioned this pull request Apr 10, 2023
Open
@no92
Copy link
Member Author

no92 commented Apr 10, 2023

Done.

@Geertiebear Geertiebear merged commit ccd70d8 into managarm:master Apr 11, 2023
@Geertiebear Geertiebear mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geertiebear Geertiebear Geertiebear approved these changes

@Dennisbonke Dennisbonke Dennisbonke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no92 @Geertiebear @Dennisbonke