This repository has been archived by the owner on Oct 3, 2019. It is now read-only.
Ps/test with postgres too #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pastromhaug
commented
Oct 18, 2018
| @@ -36,6 +35,5 @@ def test_available_for_processing_queryset(self): | |||
| tasks = SNSTask.objects.available_for_processing() | |||
| self.assertEquals(list(tasks), [ | |||
| task_ready_past, | |||
| task_ready, | |||
| task_ready_now, | |||
| ]) | |||
There was a problem hiding this comment.
This test became broken when we switched from ordering by auto-id to ordering by visible_after. Mysql just happened to continue returning objects in the same order, but postgres is not.
mattbriancon
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed tests with
py35,djangomaster, andpypy3to shrink the build matrix. Yes, these could be set up to have "allowed failures", but I still chose to remove them because Travis is throttling our builds which makes development on these libraries a pain. Includin extra builds is exacerbating that problem for very little benefit.