Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify rename message? #104

Closed
henrik opened this issue Nov 22, 2018 · 5 comments
Closed

Clarify rename message? #104

henrik opened this issue Nov 22, 2018 · 5 comments
Assignees

Comments

@henrik
Copy link

henrik commented Nov 22, 2018

I saw this deprecation message: "[DEPRECATION] This gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible."

But nothing in that message says which gem has been renamed. It wasn't hard to google the message, but if it's easy enough to push a new version of trollop, maybe it could be worth clarifying by changing "This gem" to "The trollop gem".

@kbrock
Copy link
Member

kbrock commented Nov 27, 2018

@Fryguy I created the change, but didn't have a place to merge into.

Do you want to create a trollop branch ( @ 2.9.9) so we can merge in this message change?

I was thinking:

-warn "[DEPRECATION] This gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible."
+warn "[DEPRECATION] The trollop gem has been renamed to optimist and will no longer be supported. Please switch to optimist as soon as possible."

@Fryguy
Copy link
Member

Fryguy commented Dec 4, 2018

Sounds good to me @kbrock

@kbrock
Copy link
Member

kbrock commented Dec 7, 2018

@kbrock I'm not sure how to submit a PR for this. I don't know how to target trollop and target that branch. (can we create a trollop_stable branch or something?

@Fryguy
Copy link
Member

Fryguy commented Dec 14, 2018

You can probably just push the commit directly...no need for a PR as we've discussed the wording here.

@kbrock
Copy link
Member

kbrock commented Nov 25, 2019

thanks for your help.

there is a trollop branch should we need to release any more trollop type updates

@kbrock kbrock closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants