Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v1.18.1 binary path + login doesn't persist #207

Closed
mpepping opened this issue May 14, 2024 · 1 comment · Fixed by #208
Closed

[BUG] v1.18.1 binary path + login doesn't persist #207

mpepping opened this issue May 14, 2024 · 1 comment · Fixed by #208
Assignees
Labels
bug Something isn't working

Comments

@mpepping
Copy link

Describe the bug

Bumped to v1.18.1 (from v1.18.0) and that seems to introduce two issues.

  1. The icloud command isn't in the container image path anymore. It has to be specified as /venv/bin/icloud (e.g., via docker exec)
  2. The app remains in a Retrying login every 600 seconds loop after specifying an account. Not sure if that is related to the PATH issue?

Reverting back to v1.18.0 resolves both issues.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade to v1.18.1
  2. Run docker exec -it icloud /bin/sh -c "icloud --username=<icloud-username> --session-directory=/app/session_data"
  3. See icloud command not found error

Expected behavior
Running the command should execute the command

Screenshots
If applicable, add screenshots to help explain your problem.

Configuration
If applicable, please share the configuration details

Additional context
Add any other context about the problem here.

@mpepping mpepping added the bug Something isn't working label May 14, 2024
@mandarons mandarons linked a pull request May 14, 2024 that will close this issue
@mandarons
Copy link
Owner

Oops.. sorry about that. Working on the fix...

mandarons added a commit that referenced this issue May 15, 2024
* Added /venv/bin to PATH and /app to PYTHONPATH;

* Updated docs to specify --user=icd;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants