Update CyberChef to use CyberChef icon #1054
Conversation
emtuls
added
💎 enhancement
There was a problem hiding this comment.
Thanks for the changes @emtuls! After some more testing, I am not sure that converting the image to icon is the best approach. The current code make the shortcut looks like:
But we could download and use directly the icon in https://raw.githubusercontent.com/gchq/CyberChef/18159ce806e63286019a5a6828422a992fbb253b/src/web/static/images/favicon.ico which I think looks a bit better and removes the need for the extra code:
It is also confusing and inconsistent with other apps (like capa or fakenet) that the icon in the taskbar is a different one. This is related to #1021 and #822, but I think we should address then in the same PR so that the icon change takes place everywhere.
| @@ -2,7 +2,7 @@ | |||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | |||
| <metadata> | |||
| <id>cyberchef.vm</id> | |||
| <version>10.18.3</version> | |||
| <version>10.18.3.20240523</version> | |||
There was a problem hiding this comment.
It needs update because #1052 has been merged, please rebase 😉
|
@emtuls 👀 |
…-category Fix the calls to VM-Uninstall-With-Uninstaller
| @@ -19,13 +19,13 @@ try { | |||
| Install-ChocolateyZipPackage @packageArgs | |||
| VM-Assert-Path $toolDir | |||
|
|
|||
| $iconLocation = VM-Create-Ico (Join-Path $toolDir "images\cyberchef-128x128.png") # Create .ico for cyberchef icon | |||
There was a problem hiding this comment.
@emtuls have you forgotten to push the updated changes? 🤔 This code is still creating the .ico instead of using https://raw.githubusercontent.com/gchq/CyberChef/18159ce806e63286019a5a6828422a992fbb253b/src/web/static/images/favicon.ico that seems to looks better and does not require the extra function
|
@mandiant/flare-vm Any preference or thoughts on which icon to use for Cyberchef? The other icon is just a Chef hat (also provided by Cyberchef as a Another thing to note is that the Robot-Chef mix icon requires some additional code to convert an image file to a |
This converts the CyberChef PNG file that is provided with the download and converts it to a
.icoso that Chocolatey can use it for an icon for the shortcut.Closes #966