Added static download link for NetworkMiner 2.9 #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added date suffix to version in networkminer.vm.nuspec to push the changes in chocolateyinstall.ps1 to MyGet
emtuls
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Awesome, looks good!
One minor nitpick, but not something to worry about for this PR. We like to try to keep as minimal commits as possible, so having the 2 commits for this PR be squashed into a single commit would make for it to be even cleaner.
Thank you @erik4711!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a date suffix to the version in nuspec to make sure the new zipUrl update in chocolateyinstall.ps1 gets processed