explorer: fix exception when loaded in IDA hosted under idat #1341
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
|
|
||
| pixmap = QtGui.QPixmap() | ||
| pixmap.loadFromData(ICON) | ||
| QICON = QtGui.QIcon(pixmap) |
There was a problem hiding this comment.
Source of the exception.
My initial thoughts: at some point capa_explorer.py is executed which imports capa/ida/plugin/__init__.py which imports capa/ida/plugin/icon.py resulting in execution of the referenced code. This code is invalid under idat because the Qt libraries are not loaded/init'd.
There was a problem hiding this comment.
Can confirm by executing traceback.print_stack() at capa/ida/plugin/icon.py global scope when running IDA hosted under idat
There was a problem hiding this comment.
Lesson learned: code stored at global scope of plugin and imports is executed even if the plugin returns PLUGIN_SKIP when its init method is called.
|
|
||
| pixmap = QtGui.QPixmap() | ||
| pixmap.loadFromData(ICON) | ||
|
|
||
| self.parent.setWindowIcon(QtGui.QIcon(pixmap)) |
There was a problem hiding this comment.
moved from capa/ida/plugin/icon.py; see other comments for more details
closes #1331
No issues identified when running the following command-line:
(source)