Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.3 draft? #3

Closed
rbtcollins opened this issue Feb 14, 2019 · 6 comments
Closed

Support 1.3 draft? #3

rbtcollins opened this issue Feb 14, 2019 · 6 comments

Comments

@rbtcollins
Copy link
Contributor

https://github.com/ahmadnassri/har-spec/blob/master/versions/1.3.md specifies some key fixes to HAR needed if one is dealing with binary APIs - e.g. GRPC.

Would be lovely to have that supported. What do you think?

@mandrean
Copy link
Owner

Nice! Yeah. Should be fairly simple to add. 🙌

@mandrean
Copy link
Owner

Ah, but the 1.3 proposal isn't an official draft but just a proposal by ahmadnassri, or am I mistaken?

@rbtcollins
Copy link
Contributor Author

Its not entirely clear to me what it is; what is clear is that POST bodies with binary data are completely broken under 1.2, so I'd rather be able to opt-into an un-finalised thing than generate corrupt JSON :)

@rbtcollins
Copy link
Contributor Author

Patch is up; if you like it, you could merge and push a release to crates? pretty please? :P.
There are other ergonomic things that could be done - e.g. storing the post body as a [u8] and auto setting the encoding and doing the base64 transparently etc; but just modelling whats there clearly is a pretty good start.

@mandrean
Copy link
Owner

mandrean commented Feb 14, 2019

Looks good! 👌I added a small comment on #5.

@rbtcollins
Copy link
Contributor Author

As this is merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants