-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 1.3 draft? #3
Comments
Nice! Yeah. Should be fairly simple to add. 🙌 |
Ah, but the 1.3 proposal isn't an official draft but just a proposal by ahmadnassri, or am I mistaken? |
Its not entirely clear to me what it is; what is clear is that POST bodies with binary data are completely broken under 1.2, so I'd rather be able to opt-into an un-finalised thing than generate corrupt JSON :) |
Patch is up; if you like it, you could merge and push a release to crates? pretty please? :P. |
Looks good! 👌I added a small comment on #5. |
As this is merged, closing. |
https://github.com/ahmadnassri/har-spec/blob/master/versions/1.3.md specifies some key fixes to HAR needed if one is dealing with binary APIs - e.g. GRPC.
Would be lovely to have that supported. What do you think?
The text was updated successfully, but these errors were encountered: