feat: Support HAR v1.3 proposal #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandrean
changed the title
mandrean
requested changes
Feb 14, 2019
There was a problem hiding this comment.
Looks good!
I updated the PR title to follow semantic-rs as I'm experimenting with it in this repo. I kinda like the auto-generated changelogs, auto-semver bumping & publishing to crates.io etc.
Could you maybe move up headersCompression so it's right under headersSize? Like in the 1.3 proposal. Same with encoding. OCD 🤷♀️
Otherwise awesome work 🙌
Closed
I found debugging the failing parsing excruciating with the untagged enum approach; I hope you'll consider the refactoring I've done here, though if its a problem, now that it parses, I can switch it back to untagged.
|
Changes done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found debugging the failing parsing excruciating with the
untagged enum approach; I hope you'll consider the refactoring I've
done here, though if its a problem, now that it parses, I can switch
it back to untagged.