Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump firebase from 10.6.0 to 10.7.1 #140

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps firebase from 10.6.0 to 10.7.1.

Commits
  • 05d06a8 Version Packages (#7836)
  • d6202b9 Merge master into release
  • ac10cc3 Re-enable Auth webdriver tests (#7797)
  • 0ecaf6c Add app-check-interop-types dependency to database (#7827)
  • 70e4cf6 [Auth] Detect if IndexedDB returns an empty array in platform_browser/persist...
  • 1d32137 [App Check] Install catch handler for promise in Deferred. (#7822)
  • e8ff8b8 Version Packages (#7777)
  • aa4c03d Merge master into release
  • e9ff107 [Heartbeat Service] More null service protections added to triggerHeartBeat (...
  • a5c1a35 Disable all webdriver redirect tests (#7801)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [firebase](https://github.com/firebase/firebase-js-sdk) from 10.6.0 to 10.7.1.
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.6.0...firebase@10.7.1)

---
updated-dependencies:
- dependency-name: firebase
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 18, 2023
Copy link

stackblitz bot commented Dec 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Pull Request Review

Hey there! 👋 I've summarized the previous results for you. Here's a markdown document for your pull request review:

Changes

  1. Updated firebase version from 10.6.0 to 10.7.1 in package.json. Commit

Suggestions

  1. In package.json, consider using a caret (^) instead of a specific version for the firebase package to allow for future updates: "firebase": "^10.7.1". Line 72
  2. In pnpm-lock.yaml, consider removing the dev flag for the undici package since it is set to false: "dev: false". Line 3738

Bugs

  1. In pnpm-lock.yaml, there are potential bugs in the transitivePeerDependencies section where the encoding package is not listed as a dependency anymore. This might cause compatibility issues. Line 72

Improvements

  1. In package.json, the node-fetch package has two versions listed. Consider removing the older version and keeping only the latest one: /node-fetch@2.7.0:. Line 72
  2. In package.json, the vue package has a specific version for typescript (5.0.4) listed. Consider removing the specific version and using a wildcard (*) to allow for any compatible version: "vue: 3.3.8(typescript@5.0.4)". Line 72

Rating

Overall code rating: 7.5/10

Criteria:

  • Readability: The code is generally readable, but there are some areas that could be improved.
  • Performance: Performance seems to be fine overall.
  • Security: Security seems to be fine overall.

Please review the changes, suggestions, and improvements mentioned above. Let me know if you need any further assistance! 😄

Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e75771) 20.10% compared to head (f5668fb) 20.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   20.10%   20.10%           
=======================================
  Files          28       28           
  Lines         776      776           
  Branches      200      200           
=======================================
  Hits          156      156           
  Misses        572      572           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Dec 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tachibana-shin tachibana-shin merged commit b17c5cd into main Dec 19, 2023
34 checks passed
@tachibana-shin tachibana-shin deleted the dependabot/npm_and_yarn/firebase-10.7.1 branch December 19, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant