Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anchor tags to be ignored #137

Closed
hasghari opened this issue Mar 16, 2017 · 3 comments
Closed

Allow anchor tags to be ignored #137

hasghari opened this issue Mar 16, 2017 · 3 comments
Labels
feature

Comments

@hasghari
Copy link

There is already support for ignoring style tags by using data-roadie-ignore. It would be nice if we could do the same for a[href] tags as well. My use case is using a placeholder url for mailgun like so:

<a href="%tag_unsubscribe_url%"></a>

Currently this fails because URI.parse throws an exception.
@hasghari hasghari mentioned this issue Mar 16, 2017
Closed
@Mange
Copy link
Owner

Mange commented Apr 4, 2018

This makes a lot of sense. I'd love to see a PR for it! 👍

@Mange Mange added the feature label Apr 4, 2018
@Mange Mange mentioned this issue Apr 4, 2018
Merged
@Mange
Copy link
Owner

Mange commented Apr 4, 2018

Fixed in #154.

@Mange
Copy link
Owner

Mange commented Apr 4, 2018

Version 3.3.0 was just released with this included.

@Mange Mange closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mange @hasghari