Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor has-resource graphql #757

Merged
merged 3 commits into from
Nov 22, 2019
Merged

refactor has-resource graphql #757

merged 3 commits into from
Nov 22, 2019

Conversation

davejsdev
Copy link

@davejsdev davejsdev commented Nov 22, 2019 •
edited
Loading

Reason for change

Testing

Checklist

  • CHANGELOG: The Unreleased section of CHANGELOG was updated
  • Prop changes: docs were updated
  • Prop changes: E2E tests were updated, testing from the highest level possible
  • Platform testing: If this change should be tested against a platform, has it been?

@davejsdev davejsdev requested review from a team November 22, 2019 06:15
@vercel
Copy link

vercel bot commented Nov 22, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/manifold/ui/7w5m0pmos
🌍 Preview: https://ui-git-davejs-refactor-has-resource-gql.manifold.now.sh

@drwpow drwpow temporarily deployed to manifold-ui-stage-pr-757 November 22, 2019 06:15 Inactive
@ghost ghost requested review from rselbach and sslotsky and removed request for a team November 22, 2019 06:15
davejsdev
davejsdev commented Nov 22, 2019
View reviewed changes
src/components/manifold-data-has-resource/manifold-data-has-resource.tsx
Comment on lines +68 to +70
const { data } = await this.graphqlFetch<ResourceByLabelQuery & FirstResourceQuery>({
query: label ? resourceByLabelQuery : firstResourceQuery,
variables,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be a | type, but it doesn't like that 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you can’t put a | in an object assignment here. You’d have to do { variables }: { variables: ResourceByLabelQueryVariables | FirstResourceQueryVariables }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean for this type this.graphqlFetch<ResourceByLabelQuery & FirstResourceQuery>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha. Yeah agree; not sure why that doesn’t work

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sslotsky do you have any thoughts on this before I merge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've got a full calendar for most of the day, just going to merge but let me know if you have any follow up suggestions

@davejsdev davejsdev temporarily deployed to manifold-ui-stage-pr-757 November 22, 2019 06:17 Inactive
@davejsdev davejsdev merged commit 87f4b64 into master Nov 22, 2019
@davejsdev davejsdev deleted the davejs/refactor-has-resource-gql branch November 22, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

@rselbach rselbach Awaiting requested review from rselbach

@sslotsky sslotsky Awaiting requested review from sslotsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davejsdev @drwpow