Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch aborted request errors #889

Merged
merged 2 commits into from
Jan 30, 2020
Merged

catch aborted request errors #889

merged 2 commits into from
Jan 30, 2020

Conversation

davejsdev
Copy link

@davejsdev davejsdev commented Jan 29, 2020

Reason for change

Testing

Checklist

  • CHANGELOG: The Unreleased section of CHANGELOG was updated
  • Prop changes: docs were updated
  • Prop changes: E2E tests were updated, testing from the highest level possible
  • Platform testing: If this change should be tested against a platform, has it been?

@davejsdev davejsdev requested review from sslotsky, drwpow and a team January 29, 2020 20:47
@vercel
Copy link

vercel bot commented Jan 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/manifold/ui/9br2o5bgv
✅ Preview: https://ui-git-davejs-cost-request-abort.manifold.now.sh

@drwpow drwpow temporarily deployed to manifold-ui-stage-pr-889 January 29, 2020 20:47 Inactive
if (e.name !== 'AbortError') {
this.error = 'Error getting plan cost.';
}
});
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only show a toast if the call fails for whatever reason. If aborted, just ignore it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants