xFonts 2.0 by chockenberry · Pull Request #1 · manolosavi/xFonts

chockenberry · 2020-04-28T20:47:06Z

These are all the changes that we'll be releasing as Fontcase on the App Store.

…ttings.

…d with (unused) disclosure indicator.

…ain view controller to a table view controller. UI cleanup.

… is needed).

…et bugs (love them).

manolosavi · 2020-04-29T02:25:41Z

+		self.statusLabel.text = [NSString stringWithFormat:@"%ld font%s added, %ld need%s install", addedCount, (addedCount == 1 ? "" : "s"), installCount, (installCount == 1 ? "s" : "")];
+	}
+	else {
+		self.statusLabel.text = [NSString stringWithFormat:@"%ld fonts added", addedCount];


Suggested change

self.statusLabel.text = [NSString stringWithFormat:@"%ld fonts added", addedCount];

self.statusLabel.text = [NSString stringWithFormat:@"%ld font%s added", addedCount, (addedCount == 1 ? "" : "s")];

Good catch!

manolosavi · 2020-04-29T02:26:06Z

+{
+	//DebugLog(@"%s called", __PRETTY_FUNCTION__);
+	if (previousTraitCollection.userInterfaceStyle != self.traitCollection.userInterfaceStyle) {
+		//[self loadHelpMarkdown];


is this still needed?

Nope. Test code that was forgotten :-)

manolosavi · 2020-04-29T02:28:17Z

+
+	UIFont *baseFont = [UIFont preferredFontForTextStyle:UIFontTextStyleBody];
+
+#if 1


is this if/else still needed?

Nope. The new code is simpler and more reliable.

manolosavi · 2020-04-29T02:30:18Z

+//#import "PresentationBlurAnimator.h"
+//#import "DismissBlurAnimator.h"


Suggested change

//#import "PresentationBlurAnimator.h"

//#import "DismissBlurAnimator.h"

Good cleanup!

manolosavi · 2020-04-29T02:30:36Z

+//
+//@property (nonatomic, weak) IBOutlet UITableView *tableView;
+//@property (nonatomic, weak) IBOutlet UIBarButtonItem *installButton;
+//@property (nonatomic, weak) IBOutlet UIBarButtonItem *addButton;
+//
+//@property (nonatomic, strong) NSArray<FontInfo *> *fonts;


Suggested change

//

//@property (nonatomic, weak) IBOutlet UITableView *tableView;

//@property (nonatomic, weak) IBOutlet UIBarButtonItem *installButton;

//@property (nonatomic, weak) IBOutlet UIBarButtonItem *addButton;

//

//@property (nonatomic, strong) NSArray<FontInfo *> *fonts;

Good cleanup!

manolosavi · 2020-04-29T02:31:46Z

+{
+	[super viewDidAppear:animated];
+
+#if 1


is this if/else still needed?

I'd like to keep this one in - helpful to test the overlay without clearing out all the fonts.

manolosavi · 2020-04-29T02:33:30Z

+			NSString *message = [NSString stringWithFormat:@"The mobile configuration profile could not be created.\n\nThe error was '%@'", error.localizedDescription];
+			UIAlertController *alertController = [UIAlertController alertControllerWithTitle:@"Install Error" message:message preferredStyle:UIAlertControllerStyleAlert];
+			alertController.view.tintColor = self.view.tintColor;
+			[alertController addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleCancel handler:nil]];


maybe this should be this instead?

Suggested change

[alertController addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleCancel handler:nil]];

[alertController addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleDefault handler:nil]];

Good catch!

manolosavi · 2020-04-29T02:45:30Z

-	NSString *profile = [NSString stringWithFormat:@"<?xml version=\"1.0\" encoding=\"UTF-8\"?><!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" \"http://www.apple.com/DTDs/PropertyList-1.0.dtd\"><plist version=\"1.0\"><dict><key>PayloadType</key><string>Configuration</string><key>PayloadVersion</key><integer>1</integer><key>PayloadDisplayName</key><string>xFonts (%@)</string><key>PayloadIdentifier</key><string>xFonts %@</string><key>PayloadUUID</key><string>%@</string><key>PayloadContent</key><array>%@</array></dict></plist>", title, NSUUID.UUID.UUIDString, NSUUID.UUID.UUIDString, fonts];
+	NSString *profile = [NSString stringWithFormat:profilePayloadTemplate, productName, productName, NSUUID.UUID.UUIDString, fontsPayload];
+
+	NSURL *URL = [FontInfo.storageURL URLByAppendingPathComponent:@"xFonts.mobileconfig"];


should this be renamed too?

Suggested change

NSURL *URL = [FontInfo.storageURL URLByAppendingPathComponent:@"xFonts.mobileconfig"];

NSURL *URL = [FontInfo.storageURL URLByAppendingPathComponent:@"Fontcase.mobileconfig"];

I thought about that, but it's never seen by the customer. It's kind of like the bundle ID (that uses xFonts) so I'd say leave it as-is.

manolosavi · 2020-04-29T02:49:35Z

-	NSString *fileAtPath = [self pathForFile:fileName];
-	if (![[NSFileManager defaultManager] fileExistsAtPath:fileAtPath]) {
-		[[NSFileManager defaultManager] createFileAtPath:fileAtPath contents:nil attributes:nil];
+- (void)applicationDidBecomeActive:(UIApplication *)application


this looks right to me but when running the TestFlight im not seeing it update when i come back to the app after installing. it still shows the font as "need to install" until i kill the app, and then it does show as "installed"

I think this is a bug with the Font Manager and fonts that are registered in the process scope. It sometimes doesn't refresh what's available until the process restarts. I'd like to fix it, of course, but it may be something we have to live with...

chockenberry · 2020-04-29T18:01:28Z

Thanks for going through these - you found some good stuff!

manolosavi · 2020-05-28T21:29:24Z

+Open the _Settings_ app and you’ll see a _Profile Downloaded_ button above the Airplane Mode switch. (If not, navigate to _General_ > _Profiles_ > _Downloaded Profile_ > _$(PRODUCT_NAME) Installation_.) After tapping the button, the first thing you’ll see is “Not Signed” highlighted in red.

-This is another instance where you need to trust the source of the profile and its contents. Since the profile was generated on your device, there’s no risk that it was modified in transit. But unfortunately there’s no way to sign a profile locally without exposing a secret: the private key would have to be in the app’s source code or resources.
+This is another instance where you need to trust the source of the profile and its contents. Since the profile was generated on your device, there’s no risk that it was modified in transit. This also means there's no way to sign a profile locally without exposing a secret: the private key would have to be in the app’s source code or resources.


tiny nit: not sure if intentional or not but i think maybe we should keep using ’ instead of '

Yep, I'll fix this in the next PR.

chockenberry · 2020-05-31T19:01:26Z

Famous last words: ready for release 😄

…d 15.

chockenberry · 2020-05-31T19:34:55Z

Added App Store metadata, including screenshots. See above 😄

manolosavi

think it looks good, lmk how you wanna proceed here

chockenberry added 30 commits April 15, 2020 11:27

First cleanup pass.

e072074

Started adding UIDocumentPickerViewController to add fonts.

6a17345

Added a note about accessing document picker URLs.

137c96f

Safari view controller tweaks.

10b6c3e

Added FontInfo model and reorganized code around that.

3d6553e

Removing unused resources. Added dark mode CSS for HTML.

4565a55

Tweaked text in HTML.

8889b00

File picker now uses correct tint color.

8f6c43f

Picker now copies files. Improving font registration.

d573776

Fixed problem with security scoped URL. Experimenting with opening se…

9d87157

…ttings.

Tweaked HTML. Investigating additional font info. Font list now sorte…

2666678

…d with (unused) disclosure indicator.

Moved property extraction and font registration into FontInfo.

d1f6cda

Code cleanup and removing unused files. Added named colors. Changed m…

f06918d

…ain view controller to a table view controller. UI cleanup.

Tweaked CSS. Started layout of font detail view.

3a30124

First pass at detail view.

6fa9ec3

Filling in detail view.

ad5b3b3

Cleaning up font profile generation.

3d392f8

Updated text. Constraining margins on download page.

1d2a5be

Added a tab bar.

f91fb22

Started working on the help overlay.

2f4aa80

Improved overlay layout.

e06d589

Fixing layout constraints on iPhone SE.

5413737

About view improvements.

0e10e14

Updated font preview layout and content.

5494ea9

Fixed Manolo's last name.

37cd32d

Fixed horizontal layout constraints in About view.

10a3a75

Added a text view to Help view.

4402828

Fixed help overlay on iPhone SE.

b723b19

Experimenting with checking font registration (to indicate if install…

4845946

… is needed).

Added a placeholder status header to font table view.

425948a

chockenberry added 18 commits April 25, 2020 11:50

First pass at Help. Trying out the name "Fontcase".

4513f16

TestFlight version 2.0, build 8.

31e00d7

Tweaked wording on profile description.

05dc257

Added logotype. Tweaked colors per Ged.

c1578f0

TestFlight version 2.0, build 9.

ee109cb

Added import from "Copy to" Inbox folder. Code cleanup.

9d6a163

Tweaking colors. Added info icon to status bar. Editing pass on Help.

1f95623

TestFlight version 2.0, build 10.

04f2b1f

Added a launch screen.

4390ff5

Color tweaks. New logotype. New icon.

b59c7d6

TestFlight version 2.0, build 11

a728327

Impoved help layout on wide screens.

ccf5756

Updated icon. TestFlight version 2.0, build 12.

9a0870e

Fixed install state not appearing correctly. Fixed storyboard and ass…

34a185b

…et bugs (love them).

Added monospaced trait to font details.

202f8cc

TestFlight version 2.0, build 13.

d563cc8

Create README.md

6383db6

Updated README.

202b9b9

manolosavi reviewed Apr 29, 2020

View reviewed changes

Updated code and help based on feedback.

778f9ff

manolosavi reviewed May 28, 2020

View reviewed changes

chockenberry added 2 commits May 31, 2020 11:44

TestFlight version 2.0, build 14.

7954cca

Fixed straight quotes.

35f6c8d

Added metadata for App Store submission. TestFlight version 2.0, buil…

780b4af

…d 15.

manolosavi approved these changes May 31, 2020

View reviewed changes

Added What's New.

4fa7185

manolosavi merged commit 95c20ce into manolosavi:master Jun 7, 2020

	self.statusLabel.text = [NSString stringWithFormat:@"%ld fonts added", addedCount];
	self.statusLabel.text = [NSString stringWithFormat:@"%ld font%s added", addedCount, (addedCount == 1 ? "" : "s")];


		UIFont *baseFont = [UIFont preferredFontForTextStyle:UIFontTextStyleBody];

		#if 1

		//#import "PresentationBlurAnimator.h"
		//#import "DismissBlurAnimator.h"

	[alertController addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleCancel handler:nil]];
	[alertController addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleDefault handler:nil]];

	NSURL *URL = [FontInfo.storageURL URLByAppendingPathComponent:@"xFonts.mobileconfig"];
	NSURL *URL = [FontInfo.storageURL URLByAppendingPathComponent:@"Fontcase.mobileconfig"];

Conversation

chockenberry commented Apr 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chockenberry commented Apr 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chockenberry commented May 31, 2020

Uh oh!

chockenberry commented May 31, 2020

Uh oh!

manolosavi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants