Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and simplify addon #251

Merged
merged 15 commits into from
Jan 9, 2020
Merged

Update and simplify addon #251

merged 15 commits into from
Jan 9, 2020

Conversation

mansona
Copy link
Owner

@mansona mansona commented Nov 11, 2019

This update should make the addon significantly simpler to contribute to and will also help solve a few of the issues that have been recorded.

I will be releasing this as a pre-release to help people test their applications before we release a new major version 👍

@mansona mansona force-pushed the update branch 6 times, most recently from 6a8c0d2 to fc9608a Compare November 11, 2019 15:33
@mansona
Copy link
Owner Author

mansona commented Nov 12, 2019

Hey anyone who is interested in checking out the next version 👋 you can now install the 5.0.0-0 pre-release using npm i ember-cli-notifications@next

This is a bit of a significant change in the build system but should not have changed the API too much. Please let me know if you have any issues and we can get them sorted before I release this new version

I am hoping to release this a week from today 👍

@theenadayalank
Copy link

Hi @mansona

Thanks for this great work. I had been really waiting for this update to make our host application an Embroider compatible.

Anyway, It's been a month since you released this beta version. We have tested the beta and It works fine for us. Is there anything stopping you from merging the changes to the master? I'm eagerly waiting for the stable release to use this in our application.

Once again thanks for the great work!

@mansona
Copy link
Owner Author

mansona commented Jan 9, 2020

Right folks, the time has come 🎉 I'm going to merge this as I'm confident that this has fixed most of the issues that people have been seeing.

Thanks for all the feedback and testing, and now we're starting the next chapter of this addon 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants