Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/manticore version in telemetry #2512

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

PavelShilin89
Copy link
Contributor

Type of Change (select one):
Bug fix - Issue with manticore version in telemetry

Description of the Change:
The test ensures that the Manticore Buddy telemetry feature is properly configured and functioning, providing important data about system performance and behaviour. By verifying configuration changes and daemon response, the test helps prevent configuration issues that could lead to telemetry failures or incorrect data reporting.

Related Issue (provide the link):
manticoresoftware/manticoresearch-buddy#312

Copy link

clt

👎 CLT tests in test/clt-tests/core/ test/clt-tests/expected-errors/
✅ OK: 21
❌ Failed: 1
⏳ Duration: 563s
👉 Check Action Results for commit 8b2a1ba
Failed tests:

test/clt-tests/core/test-manticore-version-in-telemetry.rec
––– input –––
apt-get install jq -y > /dev/null; echo $?
––– output –––
debconf: delaying package configuration, since apt-utils is not installed
0
––– input –––
sed -i '/data_dir = \/var\/lib\/manticore/a\    buddy_path = manticore-executor -n /usr/share/manticore/modules/manticore-buddy/src/main.php --debugv --telemetry-period=5' /etc/manticoresearch/manticore.conf
––– output –––
––– input –––
rm -f /var/log/manticore/searchd.log; searchd --stopwait > /dev/null; searchd; if timeout 10 grep -qm1 '\[BUDDY\] started' <(tail -n 1000 -f /var/log/manticore/searchd.log); then echo 'Buddy started!'; else echo 'Timeout or failed!'; cat /var/log/manticore/searchd.log;fi
––– output –––
Manticore %{SEMVER} %{COMMITDATE}#!/(\sdev)?\s/!#(columnar %{SEMVER} %{COMMITDATE}) (secondary %{SEMVER} %{COMMITDATE}) (knn %{SEMVER} %{COMMITDATE})
Copyright (c) 2001-2016, Andrew Aksyonoff
Copyright (c) 2008-2016, Sphinx Technologies Inc (http://sphinxsearch.com)
Copyright (c) 2017-%{YEAR}, Manticore Software LTD (https://manticoresearch.com)
[#!/[0-9]{2}:[0-9]{2}.[0-9]{3}/!#] [#!/[0-9]+/!#] using config file '/etc/manticoresearch/manticore.conf' (%{NUMBER} chars)...
starting daemon version '%{SEMVER} %{COMMITDATE}#!/(\sdev)?\s/!#(columnar %{SEMVER} %{COMMITDATE}) (secondary %{SEMVER} %{COMMITDATE}) (knn %{SEMVER} %{COMMITDATE})' ...
listening on %{IPADDR}:9312 for sphinx and http(s)
listening on %{IPADDR}:9306 for mysql
listening on %{IPADDR}:9308 for sphinx and http(s)
Buddy started!
––– input –––
timeout 60 bash -c 'grep -m 1 "labels:" <(tail -f /var/log/manticore/searchd.log) | sed "s/.*labels: //" | jq -M .'
––– output –––
{
"collector": "buddy",
"os_name": "Linux",
"os_release_name": "Ubuntu",
"os_release_version": "%{SEMVER} LTS (Jammy Jellyfish)",
"machine_type": "x86_64",
"machine_id": "#!/[0-9A-Za-z]+/!#",
- "dockerized": "unknown",
+ "dockerized": "yes",
"official_docker": "no",
"buddy_version": "%{SEMVER}",
"manticore_version": "%{SEMVER} %{COMMITDATE} dev",
"columnar_version": "%{SEMVER} %{COMMITDATE}",
"secondary_version": "%{SEMVER} %{COMMITDATE}",
"knn_version": "%{SEMVER} %{COMMITDATE}",
"manticore_mode": "rt",
"manticore_binlog_enabled": "yes",
"manticore_auto_optimize_enabled": "yes",
"manticore_query_log_format": "sphinxql",
"manticore_max_allowed_packet": "%{NUMBER}",
"manticore_pseudo_sharding_enabled": "yes",
"manticore_secondary_indexes_enabled": "yes",
"manticore_accurate_aggregation_enabled": "no",
"manticore_distinct_precision_threshold": "3500"
}

Copy link
Contributor

@donhardman donhardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can improve a bit matching OS (Jelly Fish) and some dynamic things that may change in future, but at all it's OK, can merge

@PavelShilin89 PavelShilin89 merged commit 9568405 into master Aug 14, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants