Fix sum file behaviour for vesuvio diffraction

[martyngigg]

Description of work.

To test:

Requires access to the ISIS archive.

The following scripts provides a basis for testing. When SumFiles=True there should be a group output with a single reduced workspace. When SumFiles=False there should be a workspace per input run.

VesuvioDiffractionReduction(InputFiles='15288,15289',
                        OutputWorkspace='DiffractionReductions',
                        SumFiles=True,
                        InstrumentParFile='IP0005.dat')

No issue number

Does not need to be in the release notes.

---

Reviewer

Please comment on the following (full description):

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
• Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
• If there are changes in the release notes then do they describe the changes appropriately?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?

• How do the changes handle unexpected situations, e.g. bad input?

• Has the relevant documentation been added/updated?

• Is user-facing documentation written in a user-friendly manner?

• Has developer documentation been updated if required?

• Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

[louisemccann]

The example works as expected but entering a range of runs in the form 22668-22674 produces the following error:

RuntimeError: Workspace2D::getSpectrum, histogram number 196 out of range 196
  at line 148 in 'C:/Users/PKB22426/Documents/Build1/mantid/Framework/PythonInterface/plugins/algorithms\LoadVesuvio.py'
  caused by line 362 in 'C:/Users/PKB22426/Documents/Build1/mantid/Framework/PythonInterface/plugins/algorithms\LoadVesuvio.py'
  at line 107 in 'C:/Users/PKB22426/Documents/Build1/mantid/Framework/PythonInterface/plugins/algorithms\WorkflowAlgorithms\VesuvioDiffractionReduction.py'
  caused by line 44 in 'C:/Users/PKB22426/Documents/Build1/mantid/scripts/Inelastic\IndirectReductionCommon.py'
  caused by line 934 in 'C:\Users\PKB22426\Documents\Build1\Build\bin\Release\mantid\simpleapi.py'
  at line 4 in 'C:/Users/PKB22426/Documents/test4.py'
  caused by line 934 in 'C:\Users\PKB22426\Documents\Build1\Build\bin\Release\mantid\simpleapi.py'

[martyngigg]

Thanks, @louisemccann. That should be fixed now.

[louisemccann]

Input as a range and comma separated list work as expected. once all tests pass

[AndreiSavici]

At some point consider refactoring

mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/VesuvioDiffractionReduction.py

Lines 202 to 207 in 410ce37

	for run in user_input:
	try:
	number_generator = IntArrayProperty('array_generator', run)
	single_files.extend(number_generator.value.tolist())
	except RuntimeError as exc:
	raise RuntimeError("Could not generate run numbers from '{0}': '{1}'".format(run, str(exc)))

It seems to me that IntArrayProperty will do the work for you, so you don't need to loop over pieces of the input string array
print(IntArrayProperty("array_generator","1-4, 7-11").value.tolist()) yields [1, 2, 3, 4, 7, 8, 9, 10, 11]

[martyngigg]

Good point. That would be much easier. Thanks.